Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Update favicon of imported items #4270

Closed
darkdh opened this issue Sep 24, 2016 · 3 comments · Fixed by #4271
Closed

Update favicon of imported items #4270

darkdh opened this issue Sep 24, 2016 · 3 comments · Fixed by #4271
Assignees
@darkdh
Labels
feature/bookmarks feature/importer misc/favicon
Milestone
0.12.3dev

Comments

@darkdh
Copy link
Member

darkdh commented Sep 24, 2016

The imported items(bookmarks, history) should have favicon
@darkdh darkdh added this to the 0.12.2dev milestone Sep 24, 2016
@darkdh darkdh self-assigned this Sep 24, 2016
@luixxiul
Copy link
Contributor

on slack

newly fetched favicons cannot be replaced, once bookmarkFile class was added to bookmarkFavicon

@luixxiul
Copy link
Contributor

luixxiul commented Sep 24, 2016 •
edited
Loading

refetching and replacing of favicons should be enabled in general. timing: on revisit, restart, hiding and showing the bookmarks toolbar

related issue -> #2075

darkdh added a commit to darkdh/browser-laptop that referenced this issue Sep 24, 2016
@darkdh
Update favicon from importer
2520fe3 
fix brave#4270

Auditors: @bbondy

Test Plan:
1. Make sure "Favicons" in "about:preferences#general" is on
2. Import bookmarks from other browser or html file
3. There should be favicon for bookmarks
@darkdh darkdh mentioned this issue Sep 24, 2016
Merged
4 tasks
@alexwykoff alexwykoff modified the milestones: 0.12.3dev, 0.12.2dev Sep 25, 2016
@alexwykoff
Copy link
Contributor

moved to 0.12.3 this shouldn't block a release

This was referenced Sep 27, 2016
Closed
Closed
Closed
Closed
This was referenced Sep 27, 2016
Closed
Closed
@srirambv srirambv mentioned this issue Sep 28, 2016
Closed
This was referenced Sep 29, 2016
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@darkdh darkdh

Labels
feature/bookmarks feature/importer misc/favicon
Projects
None yet
Milestone
0.12.3dev
Development

Successfully merging a pull request may close this issue.

Update favicon from importer darkdh/browser-laptop
3 participants
@alexwykoff @luixxiul @darkdh