Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Drag-and-drop style clicking on submenu should be enabled again #4277

Closed
luixxiul opened this issue Sep 25, 2016 · 3 comments
Closed

Drag-and-drop style clicking on submenu should be enabled again #4277

luixxiul opened this issue Sep 25, 2016 · 3 comments
Labels
addressed-with-brave-core Needs confirmation, but this issue may be resolved with Brave Core. feature/titlebar suggestion wontfix

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Sep 25, 2016

Expected behavior: Drag-and-drop style clicking on submenu should be enabled again. This has been disabled since #3854

  • Platform (Win7, 8, 10? macOS? Linux distro?): Windows 10
  • Brave Version: 0.12.2 RC4
  • Steps to reproduce:
    1. Click "File" on menubar
    2. Keep pushing the right or left mouse button
    3. Move your mouse cursor anywhere
    4. Stop pushing the mouse button on "New Tab" in the submenu of "File"
    5. New tab should be opened

This works until 0.12.1 where the windows native menu bar is used.

  • Any related issues:
@bbondy
Copy link
Member

bbondy commented Sep 26, 2016

/cc @bsclifton for after the dpi stuff

@bsclifton bsclifton self-assigned this Sep 26, 2016
@bsclifton bsclifton modified the milestones: 0.12.4dev, 0.12.3dev Sep 26, 2016
@bbondy bbondy removed this from the 0.12.4dev milestone Oct 4, 2016
@lucidNTR
Copy link
Contributor

lucidNTR commented Oct 5, 2016

also affects menus in other places that affect macOS too (the menu bar on os x is native so does not have the issue). Eg back button history menu.

  • navigate to a page and click two links to build a history
  • long click back button and keep the mouse down while dragging to the history entry you want to go to.
  • let the mouse button go.
  • nothing happens

@bsclifton
Copy link
Member

bsclifton commented Oct 5, 2016

@lucidNTR good eye- fixing that behavior is captured with #2891 😄

(sorry for the run around! your original issue was a dupe of #2891, not #4277)

@bsclifton bsclifton removed their assignment Dec 6, 2016
@cezaraugusto cezaraugusto added this to the Triage Backlog milestone Nov 8, 2017
@bsclifton bsclifton added wontfix addressed-with-brave-core Needs confirmation, but this issue may be resolved with Brave Core. labels Sep 1, 2018
@bsclifton bsclifton removed this from the Triage Backlog milestone Sep 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
addressed-with-brave-core Needs confirmation, but this issue may be resolved with Brave Core. feature/titlebar suggestion wontfix
Projects
None yet
Development

No branches or pull requests

5 participants