This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Aggressive notification #4481
Comments
|
Just seconding that I also wanted to hit an X when I seen the toolbar. Also I did see the notification twice for some reason, but I don't remember if it was with a startup in between or what else happened to give me that result. |
|
I got hit up about this over Twitter recently |
ayumi
added a commit
that referenced
this issue
Oct 31, 2016
Fix #4481 Auditors: @bsclifton Test Plan: 1. Trigger the "Payment in 24 hours, please review" notification. - Update reconcileStamp to <24 hours from now - Have sufficient funds; OR disable the sufficient funds conditional by adding false to ledger.js L1485 (showEnabledNotifications()) - Change startup notification delay in ledger.js L484 from 15m to 5s 2. Open Brave and observe 24h review notification 3. Close Brave and reopen. Notification should not reappear. (Next 24h notification timestamp is set in Application Support/brave-development/session-store-1)
ayumi
added a commit
that referenced
this issue
Oct 31, 2016
Fix #4481 Auditors: @bsclifton Test Plan: 1. Trigger the "Payment in 24 hours, please review" notification. - Update reconcileStamp to <24 hours from now - Have sufficient funds; OR disable the sufficient funds conditional by adding false to ledger.js L1485 (showEnabledNotifications()) - Change startup notification delay in ledger.js L484 from 15m to 5s 2. Open Brave and observe 24h review notification 3. Close Brave and reopen. Notification should not reappear. (Next 24h notification timestamp is set in Application Support/brave-development/session-store-1)
This was referenced Nov 2, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The info bar “Hello!Good news! Brave will pay your favorite publisher sites in less than 24 hours.” is way too aggressive. There is no way to dismiss the toolbar (no X). If you give in and click the one and only weirdly labeled button, the toolbar is dismissed temporarily only to reappear a short while later.
I must have dismissed the bugger ten times today.
It also appears inside tiny pop-up windows (like social logins and the like). Only site-specific toolbars should ever appear inside these small windows opened with JavaScript (see behavior in every other browser).
Once I’ve opened
about:preferences#paymentsfrom the toolbar, don’t show me the notification again until next month.The text was updated successfully, but these errors were encountered: