Use an about: page for About instead of a Dialog so that text selection of version info is possible

[FrancisTurner]

Help->About Brave pops up a dialog with version info. When reporting issues it woudl eb extremely useful to be able to select the text in that dialog to paste into the github text box

[Oldpedro]

In osx brave you can copy this text no problem ("Version: 0.7.11
Electron: 0.36.5
libchromiumcontent: 47.0.2526.110")

[FrancisTurner]

Not in windows. Can't select the text

[bbondy]

This is just because dialog popups don't support it on Windows which that is using.
We could perhaps move it to a new about: tab

[jbmonroe]

I don't even get Help|About Brave now.

[FrancisTurner]

Nor do I in Linux. Neither in the Help menu nor the righthand menu referenced by @jbmonroe

In windows I'm only getting it in the Help menu

[psimyn]

@FrancisTurner iirc selecting the titlebar in Windows allows ctrl c to copy contents

[FrancisTurner]

I did not know that. But yeah it appears to work.

[jbmonroe]

That doesn't work at all for me. "Selecting the titlebar?" What does that mean? Ordinarily text selection is clicking and dragging. Clicking and dragging the title bar just moves the window.

[psimyn]

@jbmonroe by "select the titlebar" I just meant click it. In windows you can ctrl + c the active window to copy the contents (for dialogs at least)

http://www.howtogeek.com/howto/windows-vista/copy-windows-error-messages-to-the-clipboard/

[jbmonroe]

For the last two builds I can't get an "About" dialog at all, so even if
Ctrl+c works, there's nothing to grab.

On 2/15/2016 7:19 PM, Simon Knox wrote:

@jbmonroe https://github.com/jbmonroe by "select the titlebar" I
just meant click it. In windows you can ctrl + c the active window to
copy the contents (for dialogs at least)

http://www.howtogeek.com/howto/windows-vista/copy-windows-error-messages-to-the-clipboard/

—
Reply to this email directly or view it on GitHub
#463 (comment).

[FrancisTurner]

It works now with the current build

Hit About this. Click anywhere in the dialog that pops up. Press CTRL-C and you get the following

[Window Title]
Brave

[Content]
Version: 0.7.15
Electron: 0.36.8
libchromiumcontent: 47.0.2526.110

[OK]

[bbondy]

I think it's more likely that we'll convert this to open an about: page with the information.
We currently use a Electron dialog for this and those work differently per platform which is not ideal.
That way it's obvious how to copy text and it's consistent between platforms.

[luixxiul]

On 0.9.6 on Windows 10 it stopped from working. CC'ing @bbondy

[luixxiul]

Confirmed this works on Ubuntu, this might be windows-only issue

[bbondy]

To fix this we just need to not use a dialog for the version info and instead use an about:brave page or similarly named. See also previous couple comments about it. I modified the title so it is more clear.

[luixxiul]

+1 from support. On Mac

[bsclifton]

I could definitely be wrong, but it might be easy to add this. We could potentially add this information here:
https://github.com/brave/browser-laptop/blob/0218b28f8a61979997485962de557a00ca5274fb/js/about/about.js