Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Brave cannot load PDFs with JS PDF reader in session tabs #4651

Closed
pureooze opened this issue Oct 10, 2016 · 2 comments · Fixed by #12138
Closed

Brave cannot load PDFs with JS PDF reader in session tabs #4651

pureooze opened this issue Oct 10, 2016 · 2 comments · Fixed by #12138

Comments

@pureooze
Copy link

pureooze commented Oct 10, 2016

Test plan

See #12138

Original issue description

Did you search for similar issues before submitting this one?
Yes.

Describe the issue you encountered:
PDF files do not load using the JS pdf reader when using a session tab. I just get a blank tab when I attempt to load a PDF in a session tab.

It works fine in non-session and private tabs.

Expected behavior:
PDF should load.

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Linux, OpenSUSE 42.1
  • Brave Version:
    0.12.4
  • Steps to reproduce:
    1. Open a new session tab
    2. Visit any link that should load a PDF
  • Screenshot if needed:
    Session tab (PDF does not load):
    image

Regular tab (PDF loads):
image

@diracdeltas
Copy link
Member

confirmed on mac that pdfjs works in private and regular tabs but not session tabs

@pureooze pureooze changed the title Brave cannot load PDFs with HTML5 PDF reader in session tabs Brave cannot load PDFs with JS PDF reader in session tabs Oct 22, 2016
@kjozwiak
Copy link
Member

This issue is reproducible in Windows as well. When loading PDF's via session tabs, you'll get the following error within the tab:

Your file was not found

It may have been moved or deleted.
ERR_FILE_NOT_FOUND

  • Platform: Win 10 x64 Build: 10.0.15063
  • Brave version: 0.18.14, 0.18.20

STR:

Example:

pdfsession

@bsclifton bsclifton added this to the Triage Backlog milestone Nov 27, 2017
@diracdeltas diracdeltas self-assigned this Nov 29, 2017
@diracdeltas diracdeltas modified the milestones: Triage Backlog, 0.20.x (Beta Channel), 0.21.x (Developer Channel) Nov 29, 2017
diracdeltas added a commit that referenced this issue Nov 29, 2017
fix #4651
probably fixes #2715 but ideally the workaround in brave/pdf.js should be removed too
may also fix other PDF loading errors
@diracdeltas diracdeltas modified the milestones: 0.21.x (Developer Channel), 0.20.x (Beta Channel) Nov 29, 2017
bsclifton pushed a commit that referenced this issue Dec 19, 2017

Unverified

This user has not yet uploaded their public signing key.
fix #4651
probably fixes #2715 but ideally the workaround in brave/pdf.js should be removed too
may also fix other PDF loading errors
diracdeltas added a commit that referenced this issue Dec 19, 2017
fix #4651
probably fixes #2715 but ideally the workaround in brave/pdf.js should be removed too
may also fix other PDF loading errors
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.