Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Pocket: chrome.browserAction.setIcon fails #4702

Closed
jonathansampson opened this issue Oct 12, 2016 · 1 comment · Fixed by #5262
Closed

Pocket: chrome.browserAction.setIcon fails #4702

jonathansampson opened this issue Oct 12, 2016 · 1 comment · Fixed by #5262
Assignees
@darkdh
Labels
feature/extensions
Milestone
0.12.8dev

Comments

@jonathansampson
Copy link
Collaborator

Describe the issue you encountered:
Calling chrome.browserAction.setIcon results in no icon being displayed.

Expected behavior:
Calling chrome.browserAction.setIcon should result in an updated browserAction icon.

Pocket uses this method to indicate when a URL has been saved.

Platform: Windows 10
Brave Version: 0.12.4

Steps to reproduce:

  1. Navigate to chrome-extension://niloccemoadcdkdjlinkgdfekeahmflj/options/options.html
  2. Open Developer Tools, Console
  3. Run chrome.browserAction.setIcon({ path: 'http://i.imgur.com/01TA7Or.jpg' })
  4. Note that no icon is displayed
  • Any related issues:
@jonathansampson jonathansampson added this to the 0.12.6dev milestone Oct 12, 2016
@jonathansampson
Copy link
Collaborator Author

This issue also impacts the Evernote extension. With Evernote, however, this method is called during initialization, which results in no icon from the start of the user's session.

@bbondy bbondy modified the milestones: 0.12.7dev, 0.12.6dev, 0.12.8dev Oct 18, 2016
@darkdh darkdh self-assigned this Oct 26, 2016
darkdh added a commit to darkdh/browser-laptop that referenced this issue Oct 29, 2016
@darkdh
browserActionBackgroundImage per-tab support
136459e 
fix brave#4702

Auditors: @bridiver, @jonathansampson

Test Plan:
1. Make sure pocket logged in
2. Save page to pocket
3. Pocket icon should change
@darkdh darkdh mentioned this issue Oct 29, 2016
Merged
4 tasks
This was referenced Nov 2, 2016
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@jonathansampson jonathansampson mentioned this issue Sep 16, 2017
Closed
4 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@darkdh darkdh

Labels
feature/extensions
Projects
None yet
Milestone
0.12.8dev
Development

Successfully merging a pull request may close this issue.

browserActionBackgroundImage per-tab support darkdh/browser-laptop
3 participants
@jonathansampson @bbondy @darkdh