Skip to content
This repository was archived by the owner on Dec 11, 2019. It is now read-only.

Additional polish needed for Bookmark Manager #4727

Closed
bsclifton opened this issue Oct 13, 2016 · 3 comments
Closed

Additional polish needed for Bookmark Manager #4727

bsclifton opened this issue Oct 13, 2016 · 3 comments
Assignees
@bsclifton
Labels
addressed-with-brave-core Needs confirmation, but this issue may be resolved with Brave Core. feature/bookmarks polish Nice to have — usually related to front-end/visual tasks. priority/P5 Cosmetic. Spelling, copy, layout. New features (which should also be part of an initiative). wontfix

Comments

@bsclifton
Copy link
Member

During code review for #4690, @jkup had 3 good concerns. This issue is to track them

cc: @bradleyrichter

  1. The page has a scrollbar even with only 1 item.
  2. Should we center the search bar on smaller devices?
  3. Is it ok that the titles aren't scrollable on smaller devices? Not sure if it matters but it means you can't read the entire thing.

Pictures for 2 & 3
screen shot 2016-10-12 at 4 26 53 pm
screen shot 2016-10-12 at 4 26 57 pm
@bsclifton bsclifton added polish Nice to have — usually related to front-end/visual tasks. feature/bookmarks labels Oct 13, 2016
@bsclifton bsclifton added this to the 0.12.6dev milestone Oct 13, 2016
@bsclifton bsclifton self-assigned this Oct 13, 2016
@bsclifton bsclifton modified the milestones: 0.12.7dev, 0.12.6dev, 0.12.8dev Oct 18, 2016
@bsclifton bsclifton removed this from the 0.12.8dev milestone Oct 26, 2016
@bsclifton bsclifton removed their assignment Oct 26, 2016
@bsclifton bsclifton added priority/P5 Cosmetic. Spelling, copy, layout. New features (which should also be part of an initiative). and removed priority/low (deprecated) labels Nov 22, 2017
@bsclifton bsclifton added this to the Backlog (Prioritized) milestone Nov 22, 2017
@pranoy10
Copy link

May I take up this issue.

@bsclifton
Copy link
Member Author

@pranoy10 sure! I'll assign the issue to myself to reserve it for you. Let me know if you have any questions 😄

@bsclifton bsclifton self-assigned this Mar 30, 2018
@NejcZdovc NejcZdovc added the help wanted The PR/issue opener needs help to complete/report the task. label May 7, 2018
@bsclifton bsclifton added addressed-with-brave-core Needs confirmation, but this issue may be resolved with Brave Core. wontfix and removed bug/good-first-bug help wanted The PR/issue opener needs help to complete/report the task. labels Jul 26, 2018
@bsclifton bsclifton removed this from the Backlog (Prioritized) milestone Jul 26, 2018
@bsclifton
Copy link
Member Author

Closing as wontfix since this is addressed with Brave Core

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bsclifton bsclifton

Labels
addressed-with-brave-core Needs confirmation, but this issue may be resolved with Brave Core. feature/bookmarks polish Nice to have — usually related to front-end/visual tasks. priority/P5 Cosmetic. Spelling, copy, layout. New features (which should also be part of an initiative). wontfix
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bsclifton @pranoy10 @NejcZdovc