-
Notifications
You must be signed in to change notification settings - Fork 974
Style updates to bookmark manager per @bradleyrichter #4690
Style updates to bookmark manager per @bradleyrichter #4690
Conversation
Here's a screenshot showing the flexability of the folders area, which fixes #1187 It has a min-width of 220px and a flex-grow of 1 (versus the other having 5). |
@bradleyrichter could you review? |
@bsclifton The import button doesn't seem to be placed correctly compared to the one above, in the preview build |
@srirambv those issues will be fixed with this PR 😄 This should also fix a failing test |
Ideally we would have ellipses after a max width and a full-text on hover. Later, drag-adjust column widths. Please don't force the column width to fit the long folder names. |
@bradleyrichter should there be a max width setting? Adding that would be fairly easy. Overflow can be handled with either ellipsis or by adding a horizontal scroll bar at the bottom |
Screen caps of some of the changes we did: New "All Folders"shows when you do a search (otherwise hidden): Demo of the new color highlights for sortableTablecc: @darkdh |
Bookmarks Manager - searching now shows "All Folders" with magnifying glass at top of folder list - if search is done, selected folder doesn't show as picked - colors tweaked for hover/selected in folder list - reduced size of bookmark import icon, updated color to @buttonColor - "Folder" text no longer selectable Sortable table (affects about:history and preferences > search) - Highlight color changed (was orange, now is gray, matching folder selection) - Hover color changed (was light yellow/orange, now is light gray) - Highlight/hover text color changed to be @buttonColor - Box shadow and border removed History page - Entries are no longer selectable. Often, multi-select would select the actual text too Auditors: @bradleyrichter
Sweet- thanks for the feedback, @jkup! I'll can work on a fix for 1 and 3 in a follow up 😄 @bradleyrichter what do you think about 2? (should the search box be centered if you reduce the window size- see @jkup's pic) |
I'll go ahead and merge- @bradleyrichter I can address those items in a follow up (0.12.6, when adding folders). Please let me know! |
git rebase -i
to squash commits (if needed).Fixes #4562
Fixes #2652
Auditors: @jkup @bbondy
Test Plan: