Nested bookmark folders go off screen in bookmarks toolbar

[bsclifton]

Did you search for similar issues before submitting this one?
Yes

Describe the issue you encountered:
When user has a large amount of nested bookmark folders, they'll end up going off screen instead of being able to show all the folders.

Expected behavior:
Folders should show (see screenshot below, with Chrome behavior)

• Platform (Win7, 8, 10? macOS? Linux distro?):
  All
• Brave Version:
  All
• Steps to reproduce:
  1. Go to about:bookmarks
  2. Create 20 - 30 folders and nest them all
  3. Ensure bookmarks toolbar is being shown
  4. Open the folder using bookmarks toolbar
• Screenshot if needed:

screenshot from 0.12.5

screenshot showing Brave (top) vs Chrome (bottom) behavior (thanks @srirambv!)

• Any related issues:
  Nested bookmark folders go off screen on about:bookmarks #1187

[bsclifton]

+1 from #8891 (bookmarks toolbar expansion menus are running past the right edge of the window)

[srirambv]

+1 from #10388

[LaurenWags]

+1 from me

[alexwykoff]

@bsclifton what is blocking this? Does it depend on any DPI fixes?

[bsclifton]

@alexwykoff no blockers

In order to solve this, we would need to convert the menus from React controls (HTML/JavaScript) to native menu items (ex: uses win32 / gtk / cocoa). We've done this with a few menus (ex: the popup menu that shows when you right click a page), but not anything that has an icon (1Password and others will load icons and pass them to us, but we don't load any icons).

We would need to convert the favicons into NativeImage format (something I'm not sure that we have done yet in our code). Just a heads up- doing this will break related webdriver tests

[bsclifton]

@alexwykoff related tracking issue:

Convert React ContextMenu items to native context menu #8641

[srirambv]

+1 from community https://community.brave.com/t/bug-report-drop-down-menu/11781/2

[eljuno]

+1 from community https://community.brave.com/t/cant-see-the-rest-of-bookmark-when-the-screen-ends/14146?u=eljuno

[eljuno]

+1 from community https://community.brave.com/t/bookmark-displays-folder-content-off-screen/14650?u=eljuno

[eljuno]

+1 from community https://community.brave.com/t/bookmark-bug-unseen-here/16440?u=eljuno

The bookmarks is not showing properly on the right side

[LaurenWags]

+1 from community: https://community.brave.com/t/multi-tier-bookmarks-go-outside-browser-window-and-are-inaccessible/21852

[eljuno]

+1 from Twitter https://twitter.com/irpolarbear/status/1012076883066974208

Fixed with brave-core, @bsclifton @srirambv ?

[srirambv]

@eljuno Yes this will be fixed by brave-core. @bsclifton this issue can be closed as its out-of-box fix on brave-core.

[JamborJan]

From my point of view it is not a good thing to close an issue with a "wontfix" without pointing to the solution. There is no issue "out-of-box fix", the latest version of brave doesn't solve the problem. Users are not able to check the status of the problem. Just saying.

[bsclifton]

@JamborJan the solution is Brave Core which you can find here:
https://github.com/brave/brave-browser

Unfortunately, there are no public binaries currently available... but we should have some available within the next month or two. If you wanted to try it yourself, you can compile from source. This issue is closed as wontfix because we will not be fixing it with our current codebase (which is based on Muon, a fork of Electron)

[bsclifton]

Here's a screenshot from the current live build of Brave Core where the issue is fixed: