Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Convert React ContextMenu items to native context menu #8641

Closed
2 of 4 tasks
bsclifton opened this issue May 2, 2017 · 5 comments
Closed
2 of 4 tasks

Convert React ContextMenu items to native context menu #8641

bsclifton opened this issue May 2, 2017 · 5 comments
Labels
feature/context-menu fixed-with-brave-core This issue will automatically resolved with the replacement of Muon with Brave Core. priority/P5 Cosmetic. Spelling, copy, layout. New features (which should also be part of an initiative). project-tracking wontfix

Comments

@bsclifton
Copy link
Member

bsclifton commented May 2, 2017

This issue is meant to track places which use our React component which we can convert to using native context menus. This works great on Windows and Linux, but macOS causes video to freeze when the context menu is presented. The above PR makes that process async

Places we can update:

Places we can consider updating (which have moderate difficulty):

Places which we shouldn't change (requires a lot of extra work to do natively):

cc: @liunkae

@bsclifton bsclifton added this to the 1.2.0 milestone May 2, 2017
@cndouglas
Copy link

@bsclifton What about the Windows menubar?

@bsclifton
Copy link
Member Author

bsclifton commented May 3, 2017

@liunkae that would be a REALLY nice one actually! Good catch 😄

(please edit the original post if needed)

@darkdh
Copy link
Member

darkdh commented Jun 7, 2017

I do see something about drag and drop handling in MenuController of ui/views/controls/menu/menu_controller.cc

@bsclifton
Copy link
Member Author

@liunkae did you want to redo the reload/stop button with native context menu? I remember you had originally submitted the PR with it as a native menu, but we changed back (at my request, since macOS menus were sync at the time)

@cndouglas
Copy link

Sure. I opened #9571 for this.

@alexwykoff alexwykoff modified the milestones: 1.2.0, Backlog Nov 1, 2017
@bsclifton bsclifton added project-tracking Epic priority/P5 Cosmetic. Spelling, copy, layout. New features (which should also be part of an initiative). and removed Epic labels Nov 7, 2017
@NejcZdovc NejcZdovc modified the milestones: Triage Backlog, Prioritized Backlog Nov 21, 2017
@bsclifton bsclifton added wontfix fixed-with-brave-core This issue will automatically resolved with the replacement of Muon with Brave Core. labels Aug 24, 2018
@bsclifton bsclifton removed this from the Backlog (Prioritized) milestone Aug 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature/context-menu fixed-with-brave-core This issue will automatically resolved with the replacement of Muon with Brave Core. priority/P5 Cosmetic. Spelling, copy, layout. New features (which should also be part of an initiative). project-tracking wontfix
Projects
None yet
Development

No branches or pull requests

5 participants