Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Enable Save button on Autofill modal only when user adds details #4855

Closed
srirambv opened this issue Oct 17, 2016 · 0 comments · Fixed by #4875
Closed

Enable Save button on Autofill modal only when user adds details #4855

srirambv opened this issue Oct 17, 2016 · 0 comments · Fixed by #4875

Comments

@srirambv
Copy link
Collaborator

Did you search for similar issues before submitting this one?
No

Describe the issue you encountered:
Currently save button is enabled by default. Clicking on it without entering details does nothing.

Expected behavior:
Enable Save button on Autofill modal only when user adds details. Functionality should be similar to adding bookmark modal

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    All
  • Brave Version:
    0.12.5 RC3
  • Steps to reproduce:
    1. Open about:autofill
    2. Click on add address
    3. Save button is enabled on modal. Clicking on it without entering details closes the modal but doesn't save anything.
  • Screenshot if needed:
  • Any related issues:
    cc: @darkdh
    Setting milestone as 0.12.6 for now.
@srirambv srirambv added this to the 0.12.6dev milestone Oct 17, 2016
@darkdh darkdh self-assigned this Oct 17, 2016
darkdh added a commit to darkdh/browser-laptop that referenced this issue Oct 17, 2016
fix brave#4855

Auditors: @bbondy

Test Plan:
1. Open "about:autofill"
2. Click "Add Address"
3. The save button should be disabled
4. Enter the detail of form, the save button should be enabled
5. Remove all detail of form, the save button should be disabled

1. Open "about:autofill"
2. Click "Add Credit Card"
3. The save button should be disabled
4. Enter the detail of form, the save button should be enabled (Name, Card Number)
5. Remove all detail of form, the save button should be disabled (Name, Card Number)

1. Open "about:autofill"
2. Add address entry
3. Edit the address entry
4. Remove all detail of form, the save button should be disabled

1. Open "about:autofill"
2. Add credit card entry
3. Edit the credit card entry
4. Remove all detail of form, the save button should be disabled (Name, Card Number)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants