This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 974
Enable Save button on Autofill modal only when user adds details #4855
Comments
darkdh
added a commit
to darkdh/browser-laptop
that referenced
this issue
Oct 17, 2016
fix brave#4855 Auditors: @bbondy Test Plan: 1. Open "about:autofill" 2. Click "Add Address" 3. The save button should be disabled 4. Enter the detail of form, the save button should be enabled 5. Remove all detail of form, the save button should be disabled 1. Open "about:autofill" 2. Click "Add Credit Card" 3. The save button should be disabled 4. Enter the detail of form, the save button should be enabled (Name, Card Number) 5. Remove all detail of form, the save button should be disabled (Name, Card Number) 1. Open "about:autofill" 2. Add address entry 3. Edit the address entry 4. Remove all detail of form, the save button should be disabled 1. Open "about:autofill" 2. Add credit card entry 3. Edit the credit card entry 4. Remove all detail of form, the save button should be disabled (Name, Card Number)
4 tasks
This was referenced Oct 20, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Did you search for similar issues before submitting this one?
No
Describe the issue you encountered:
Currently save button is enabled by default. Clicking on it without entering details does nothing.
Expected behavior:
Enable Save button on Autofill modal only when user adds details. Functionality should be similar to adding bookmark modal
All
0.12.5 RC3
cc: @darkdh
Setting milestone as 0.12.6 for now.
The text was updated successfully, but these errors were encountered: