Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fully qualified domains entered in full should sort higher than history items with longer URL #4861

Closed
aekeus opened this issue Oct 17, 2016 · 4 comments
Closed

Fully qualified domains entered in full should sort higher than history items with longer URL #4861

aekeus opened this issue Oct 17, 2016 · 4 comments
Assignees
@aekeus
Labels
QA/checked-Linux QA/checked-macOS QA/checked-Win64
Milestone
0.12.6dev

Comments

@aekeus
Copy link
Member

aekeus commented Oct 17, 2016 •
edited
Loading

If a user types a fully qualified domain name i.e. (google.com) we should not sort URLs such as google.com/info higher.
@aekeus aekeus self-assigned this Oct 17, 2016
@bbondy
Copy link
Member

bbondy commented Oct 17, 2016

would love for 0.12.6 if you have time today.

@aekeus aekeus added this to the 0.12.6dev milestone Oct 17, 2016
aekeus added a commit that referenced this issue Oct 17, 2016
@aekeus
URLs without query parameters, paths or hash components should sort b…
1e55aa0 
…efore URLs with these items.

Auditors: @bbondy

Fixes: #4861

Test Plan:

  0. Start with new session file
  1. visit google.com
  2. visit google.com and do a search
  3. Open a number browser and type goo
  4. Ensure google.com is the first auto-selected option
@aekeus
Copy link
Member Author

aekeus commented Oct 17, 2016

Fixed in #4809 pull request

@aekeus aekeus closed this as completed Oct 17, 2016
This was referenced Oct 20, 2016
Closed
Closed
@alexwykoff
Copy link
Contributor

This is not currently working in Preview 1.

@alexwykoff alexwykoff reopened this Oct 20, 2016
@aekeus
Copy link
Member Author

aekeus commented Oct 20, 2016

@alexwykoff any details about what you were expecting?

@aekeus aekeus closed this as completed Oct 20, 2016
@alexwykoff alexwykoff mentioned this issue Oct 21, 2016
Closed
@alexwykoff alexwykoff mentioned this issue Oct 22, 2016
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@aekeus aekeus

Labels
QA/checked-Linux QA/checked-macOS QA/checked-Win64
Projects
None yet
Milestone
0.12.6dev
Development

No branches or pull requests
4 participants
@aekeus @bbondy @alexwykoff @srirambv