Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

getSetting() should return the correct vale #4903

Closed
darkdh opened this issue Oct 18, 2016 · 0 comments · Fixed by #4907
Closed

getSetting() should return the correct vale #4903

darkdh opened this issue Oct 18, 2016 · 0 comments · Fixed by #4907
Assignees
@darkdh
Labels
QA/checked-Linux QA/checked-macOS QA/checked-Win64
Milestone
0.12.6dev

Comments

@darkdh
Copy link
Member

darkdh commented Oct 18, 2016 •
edited
Loading

it will return undefined if the setting is false. It affect the explicit check like title mode

889757e#commitcomment-19471078
@darkdh darkdh added this to the 0.12.6dev milestone Oct 18, 2016
@darkdh darkdh self-assigned this Oct 18, 2016
darkdh added a commit to darkdh/browser-laptop that referenced this issue Oct 18, 2016
@darkdh
Do not use default setting when value is false
d2dff91 
fix brave#4903

Auditors: @bbondy

Test Plan:
1. Turn on/off "Always show the URL bar" in about:preferences#general
2. The title mode should work as expected
@darkdh darkdh modified the milestones: 0.12.5dev, 0.12.6dev Oct 18, 2016
@luixxiul luixxiul modified the milestones: 0.12.6dev, 0.12.5dev Oct 18, 2016
darkdh added a commit to darkdh/browser-laptop that referenced this issue Oct 18, 2016
@darkdh
Do not use default setting when value is false
1092758 
fix brave#4903

Auditors: @bbondy

Test Plan:
1. Turn on/off "Always show the URL bar" in about:preferences#general
2. The title mode should work as expected
@darkdh darkdh mentioned this issue Oct 18, 2016
Merged
4 tasks
This was referenced Oct 20, 2016
Closed
Closed
@alexwykoff alexwykoff mentioned this issue Oct 22, 2016
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@darkdh darkdh

Labels
QA/checked-Linux QA/checked-macOS QA/checked-Win64
Projects
None yet
Milestone
0.12.6dev
Development

Successfully merging a pull request may close this issue.

Do not use default setting when value is false darkdh/browser-laptop
4 participants
@alexwykoff @luixxiul @darkdh @srirambv