This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
default browser check should run only on release build #4958
Assignees
Milestone
Comments
darkdh
added a commit
to darkdh/browser-laptop
that referenced
this issue
Oct 19, 2016
fix brave#4958 Auditors: @bridiver, @bbondy Test Plan: npm start or npm run test should not popup the check default browser modal
4 tasks
darkdh
added a commit
to darkdh/browser-laptop
that referenced
this issue
Oct 19, 2016
fix brave#4958 Auditors: @bridiver, @bbondy Test Plan: 1. Make sure there is no session data 2. npm run start/test should not popup the check default browser modal. 3. BRAVE_FORCE_CHECK_DEFAULT_ON_STARTUP=true npm run start/test should popup the check default browser modal normally.
darkdh
added a commit
to darkdh/browser-laptop
that referenced
this issue
Oct 19, 2016
BRAVE_IS_DEFAULT_BROWSER for test purpose fix brave#4958 Auditors: @bridiver, @bbondy Test Plan: 1. Make sure there is no session data 2. npm run start/test should not popup the check default browser modal and overrides brave as default browser. 3. BRAVE_IS_DEFAULT_BROWSER=true npm run start/test should not popup the check default browser modal and overrides brave as default browser. 4. BRAVE_IS_DEFAULT_BROWSER=false npm run start/test should popup the check default browser modal and overrides brave not be default browser.
This was referenced Oct 20, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
we should skip
NODE_ENV=test
NODE_ENV=development
The text was updated successfully, but these errors were encountered: