Maximizing browser extends into second monitor

[ETapia1]

Test plan

1. Have a dual monitor Windows setup
2. Open Brave and maximize it on one of the windows
3. There shouldn't be any border from Brave.exe on the other monitor (see below picture)

Original issue description

Did you search for similar issues before submitting this one?
yes
Describe the issue you encountered:
when I click the maximize button (by the close button not f11) the browser over-extends on to my second monitor. I can hover over the excess pixels and it gives me the option to stretch the window (double sided arrows) but it won't expand because it's already maximized on my main monitor. I've already reinstalled my OS. The issued still persists. Now there is also an issue when I go full screen on a video. It creates an annoying blue border around the video. this didn't happen before so I'm not sure if it's a related issue.
Expected behavior:
Maximize window without overlapping onto my second monitor.

• Platform (Win7, 8, 10? macOS? Linux distro?):
  Windows 10
• Brave Version:
  0.12.6
• Steps to reproduce:
  1. have two monitors
  2. click maximize button
     3.
• Screenshot if needed:
• Any related issues:
  Blue border around full-screen videos.
  
  
  Blue lines around the border of video in fullscreen #5119

[Superbest]

I also get this with Windows 7. I believe it's been happening at least for 3 weeks now. It wasn't an issue more than 2 months ago, I think either version 0.8 or 0.9 was the last one without this issue.

[andrewcole50]

Happens to me to. Whichever side I maximize Brave on It extends ~5-10 pixels over to the next screen. Oddly enough pressing F11 produces a properly maximized window but the maximize button or dragging the window to the top of the screen produces the bug.

Windows 10 x64

[Superbest]

Some weird observations:

1. It bleeds from horizontal right monitor (main screen) to the vertical left monitor (second screen), but not from left monitor to right monitor.
2. Once it bleeds, I can minimize and restore the window and the bleed is removed.
3. When the bleed is removed, I can restore and re-maximize the window and it bleeds again.

This is on Brave 0.12.10 by the way.

[bsclifton]

With the recent updates in 0.13.0, we should retest this 😄 It may very well be fixed now (if not, I have some good ideas for fixes)

[bsclifton]

This issue is definitely Windows only; here's an article describing the history behind why Windows behaves like this for maximized windows:
https://blogs.msdn.microsoft.com/oldnewthing/20120326-00/?p=8003

The potential fix would be in brave/muon. We could force the window to stay within the bounds of the monitor by handling the WM_GETMINMAXINFO event and changing the dimensions there.

[bsclifton]

+1 from user @benjaminsuch via #7997

[lukemulks]

We've had a Brave Community contributor report a ~1-3px overlap between monitors when Brave is maximized in a primary display, when there are two displays sitting side by side.

URL to Brave Community thread:
https://community.brave.com/t/youtube-skip-ad-button-disappeared-brave-window-overlaps-other-screen/2329/8

Browser profile for user:

Brave: 0.15.0 
rev: 71fb73001617949528cc6473e288a49e76fcd4d5 
Muon: 2.58.7 
libchromiumcontent: 58.0.3029.81 
V8: 5.8.283.32 
Node.js: 7.9.0 
Update Channel: dev 
os.platform: win32 
os.release: 10.0.15063 
os.arch: x64

Screenshots provided by our contributor:

[bsclifton]

@alexwykoff I think you said you may have a way to test multiple monitors... It may not be fixed, but worth a retest for sure

[bsclifton]

If this fails QA, let's re-open and remove the milestone 😄

[bsclifton]

Re-opening and unassigning milestone. Per @jonathansampson:

A maximized window on second monitor bleeds a few pixels over into the first monitor.
Similarly, a maximized window on the first monitor bleeds a couple pixels over into the second monitor.

[jonathansampson]

@bsclifton Just downloaded fc4b892, and this issue no longer repros for me.

[bsclifton]

@jonathansampson awesome! thanks for the report 😄 In that case, I'll re-close and move back to 0.15.300