Imported bookmarks should set creationTime field (not lastAccessedTime)

[srirambv]

Did you search for similar issues before submitting this one?
No

Describe the issue you encountered:
Deleting an imported bookmark doesn't delete the history entry. This comes up as a history suggestion

Expected behavior:
Deleting an imported bookmark should delete its entry from history as well

• Platform (Win7, 8, 10? macOS? Linux distro?):
  All

• Brave Version:
  0.12..7 RC1

• Steps to reproduce:

  1. Import bookmarks from a file or another browser
  2. Delete the imported bookmark
  3. Type the site name in URL, the deleted bookmark shows up as a history suggestion

• Screenshot if needed:
  

• Any related issues:

  cc: @bsclifton Setting milestone as 0.12.8

[bbondy]

I don't think this is right, I think deleting a bookmark should be independent of if it shows up in history, if the last access time was set from an import, it should remain there.

[bbondy]

Going to close as wontfix, but lmk if you strongly disagree.

[bsclifton]

@bbondy I know someone had opened a similar one and I felt the same way (can't find that ticket...) This one seems to be different because it's related to import (not just deleting a bookmark). It's entirely possible that the user never visited the sites they have imported

Removing a bookmark only removes the tags (not the entry- basically turning it into a history entry)... The real issue here might be that entries in sites should not be considered history items unless there is an associated timestamp. If that's the case, it might be better to reword this ticket as "don't consider entries history unless timestamp is associated". siteUtils already has an "isHistoryEntry" method which checks this

[bbondy]

I think if last access date is filled out from a history import then it should be considered a history entry as well. I think if it was never visited last access date will be 0, but I can definitely be wrong on that's how it works (I think it should work that way though). CC @darkdh for his thoughts.

[darkdh]

Imported History and Bookmark all have lastAccessedTime info, I think it's my bad to use bookmark creation time as lastAccessedTime when importing bookmarks.
I can definitely to make it 0, what do you think, @bbondy?

[bbondy]

is there a lastAccessTime and a creation time you can use? If only creation time is avail maybe set a new field for that and it will be unused for now.

[darkdh]

we don't have lastAccessTime when importing bookmarks but I can add a creationTime field for later use

[bsclifton]

Updated the title to reflect the current status. Thanks, @darkdh 😄

[alexwykoff]

Could not verify in OS X 0.12.8 RC1

[srirambv]

On Windows too. Entry shows up in history suggestion but not shown in about:history

cc: @darkdh