Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Remove data URL PNG from preferences.less #5224

Closed
bbondy opened this issue Oct 28, 2016 · 0 comments
Closed

Remove data URL PNG from preferences.less #5224

bbondy opened this issue Oct 28, 2016 · 0 comments
Labels
QA/checked-Linux QA/checked-macOS QA/test-plan-specified refactoring release-notes/include
Milestone
0.13.5

Comments

@bbondy
Copy link
Member

bbondy commented Oct 28, 2016 •
edited by bsclifton
Loading

Test Plan

  • Open up content dev tools using F12 or alt + option + i
  • Select the two images shown below in preferences > payments
  • ensure logo is a PNG file

Original issue details

This line causes my vim editor to freeze for several seconds anytime I make any change to preferences.less. base64 data URLs don't belong there, would love to have this cleaned up.
https://github.com/brave/browser-laptop/blob/master/less/about/preferences.less#L1038
michalbe added a commit to michalbe/browser-laptop that referenced this issue Feb 13, 2017
@michalbe
Remove Base64 encoded images from preferences.less
a36f2a6 
Fixes brave#5224
michalbe added a commit to michalbe/browser-laptop that referenced this issue Feb 13, 2017
@michalbe
Remove Base64 encoded images from preferences.less
0f60db3 
Fixes brave#5224
@michalbe michalbe mentioned this issue Feb 13, 2017
Merged
4 tasks
@bsclifton bsclifton added this to the 0.13.4 milestone Feb 13, 2017
This was referenced Feb 26, 2017
Closed
Closed
Closed
Closed
Closed
This was referenced Mar 3, 2017
Closed
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
QA/checked-Linux QA/checked-macOS QA/test-plan-specified refactoring release-notes/include
Projects
None yet
Milestone
0.13.5
Development

No branches or pull requests
3 participants
@bbondy @alexwykoff @bsclifton