Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Showing findbar and typing fast sometimes would append text instead of replacing selection #5289

Closed
bbondy opened this issue Oct 31, 2016 · 0 comments
Closed

Showing findbar and typing fast sometimes would append text instead of replacing selection #5289

bbondy opened this issue Oct 31, 2016 · 0 comments
Labels
feature/findbar QA/no-qa-needed
Milestone
0.12.8dev

Comments

@bbondy
Copy link
Member

bbondy commented Oct 31, 2016

This is best tested with an automated test since it can reproduce 100% of the time.
npm run test -- --grep="findbar text should be replaced and never appended"
@bbondy bbondy added this to the 0.12.8dev milestone Oct 31, 2016
@bbondy bbondy closed this as completed in 9d1547a Oct 31, 2016
bbondy added a commit that referenced this issue Nov 1, 2016
@bbondy
Findbar focus twice should select text
649630f 
This was introduced with #5289

Fix #5289

Auditors: @diracdeltas
bbondy added a commit that referenced this issue Nov 2, 2016
@bbondy
Findbar focus twice should select text
60c15d8 
This was introduced with #5289

Fix #5289

Auditors: @diracdeltas
This was referenced Nov 2, 2016
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
feature/findbar QA/no-qa-needed
Projects
None yet
Milestone
0.12.8dev
Development

No branches or pull requests
3 participants
@bbondy @alexwykoff @luixxiul