Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Per tab browserActions data should be clear when navigating #5327

Closed
darkdh opened this issue Nov 1, 2016 · 0 comments · Fixed by #5339
Closed

Per tab browserActions data should be clear when navigating #5327

darkdh opened this issue Nov 1, 2016 · 0 comments · Fixed by #5339
Assignees
@darkdh
Labels
feature/extensions QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64
Milestone
0.12.8dev

Comments

@darkdh
Copy link
Member

darkdh commented Nov 1, 2016

In chrome/browser/extensions/tab_helper.cc:

void TabHelper::DidNavigateMainFrame(
    const content::LoadCommittedDetails& details,
    const content::FrameNavigateParams& params) {
  ...
  if (!details.is_in_page)
    ExtensionActionAPI::Get(context)->ClearAllValuesForTab(web_contents());
}

We should clear the data when navigation happen just like chrome.

Example of not doing this:
pocket-icon
@darkdh darkdh added this to the 0.12.8dev milestone Nov 1, 2016
@darkdh darkdh self-assigned this Nov 1, 2016
darkdh added a commit to darkdh/browser-laptop that referenced this issue Nov 2, 2016
@darkdh
Clear per-tab browserAction data when navigation happens
8b2c828 
fix brave#5327

Auditors: @bridiver, @bbondy

Test Plan:
1. Go to about:preferences#advanced and enable pocket
2. Login pocket
3. Navigate to arbitrary page
4. Save page to pocket
5. Navigate to other page/refresh the page
6. The pocket icon should not be illuminated
@darkdh darkdh mentioned this issue Nov 2, 2016
Merged
4 tasks
darkdh added a commit to darkdh/browser-laptop that referenced this issue Nov 2, 2016
@darkdh
Clear per-tab browserAction data when navigation happens
b82d6d3 
fix brave#5327

Auditors: @bridiver, @bbondy

Test Plan:
1. Go to about:preferences#advanced and enable pocket
2. Login pocket
3. Navigate to arbitrary page
4. Save page to pocket
5. Navigate to other page/refresh the page
6. The pocket icon should not be illuminated
bbondy pushed a commit that referenced this issue Nov 4, 2016
@darkdh @bbondy
Clear per-tab browserAction data when navigation happens
b490e6c 
fix #5327

Auditors: @bridiver, @bbondy

Test Plan:
1. Go to about:preferences#advanced and enable pocket
2. Login pocket
3. Navigate to arbitrary page
4. Save page to pocket
5. Navigate to other page/refresh the page
6. The pocket icon should not be illuminated
This was referenced Nov 4, 2016
Closed
Closed
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@darkdh darkdh

Labels
feature/extensions QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64
Projects
None yet
Milestone
0.12.8dev
Development

Successfully merging a pull request may close this issue.

Clear per-tab browserAction data when navigation happens darkdh/browser-laptop
4 participants
@alexwykoff @luixxiul @darkdh @srirambv