Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Submit feedback in pref page/hamburger menu doesn't work #5352

Closed
srirambv opened this issue Nov 2, 2016 · 0 comments
Closed

Submit feedback in pref page/hamburger menu doesn't work #5352

srirambv opened this issue Nov 2, 2016 · 0 comments

Comments

@srirambv
Copy link
Collaborator

srirambv commented Nov 2, 2016

Did you search for similar issues before submitting this one?
Yes

Describe the issue you encountered:
Submit feedback in pref page/hamburger menu doesn't work

Expected behavior:
Should launch the email client on the machine to submit feedback

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Windows 10 x64

  • Brave Version:
    0.12.6, 0.12.7, 0.12.8 Preview 2

  • Steps to reproduce:

    1. Open preferences page
    2. Click submit feedback link after helpful hints, doesnt launch the email client
    3. Open Hamburger menu>help>submit feedback, doesn't launch the email client
  • Screenshot if needed:
    image

  • Any related issues:
    Help -> Submit Feedback is not opening the mail client for certain users #4487

@srirambv srirambv added this to the 0.12.8dev milestone Nov 2, 2016
bbondy added a commit that referenced this issue Nov 4, 2016
bbondy added a commit that referenced this issue Nov 4, 2016
bbondy added a commit that referenced this issue Nov 4, 2016
@bbondy bbondy closed this as completed in c73844c Nov 4, 2016
bbondy added a commit that referenced this issue Nov 4, 2016
Fix #5352
Fix #4795

I stll need to add some automated tests for this section of code but it was also
not in testing before.

Test Plan:
- On each OS test opening .html files both whent he browser is
  started and not started.
- Type a mailto: link and http: link in Slack and click them both when
  the browser is started and not started.
- Try setting Brave as the mailto handler and not.

Auditors: @aekeus
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants