Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

regression: double-clicking of entries on about:history opens nothing #5353

Closed
luixxiul opened this issue Nov 2, 2016 · 0 comments
Closed

regression: double-clicking of entries on about:history opens nothing #5353

luixxiul opened this issue Nov 2, 2016 · 0 comments
Assignees
@bsclifton
Labels
bug feature/history QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64
Milestone
0.12.8dev

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Nov 2, 2016

Describe the issue you encountered: regression: double-clicking of entries on about:history opens nothing. You can open the sites only with the context menu.

Expected behavior:
@luixxiul luixxiul added this to the 0.12.8dev milestone Nov 2, 2016
@bsclifton bsclifton self-assigned this Nov 3, 2016
@bsclifton bsclifton mentioned this issue Nov 3, 2016
Merged
4 tasks
bbondy pushed a commit that referenced this issue Nov 4, 2016
@bsclifton @bbondy
Pulled code from about:history into a new historyUtil module
8d13095 
Fixes #5353

This has regressed at least once before; we need a way besides web driver to test the code.
(usually, problem is immutable vs mutable; ex: ".get method not found", etc)

Auditors: @bbondy

Test Plan:
1. Launch Brave and visit about:history
2. Double click any entry
3. Enjoy :)
This was referenced Nov 4, 2016
Closed
Closed
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bsclifton bsclifton

Labels
bug feature/history QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64
Projects
None yet
Milestone
0.12.8dev
Development

No branches or pull requests
4 participants
@alexwykoff @luixxiul @bsclifton @srirambv