You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
I'm not fully sure why it happens but I have a fix. It's something about typing fast when another tab is loading. Also I removed the mixed input controlled type because React gives a warning about it (We still do it on the URL bar though). I do have a test that fails consistently that works now.
The text was updated successfully, but these errors were encountered:
Test plan: I could reproduce this by opening the new tab page, then open 2 tabs with command+click, then find in page on the first.
I did find a way to write an automated test that reproduces this with the old code, and it is fixed in the new code.
This gets rid of the warning that React gives about a controlled component. It also fixes the problem with when state updates because a background tab changes, it should not re-select text
Fix#5363
I'm not fully sure why it happens but I have a fix. It's something about typing fast when another tab is loading. Also I removed the mixed input controlled type because React gives a warning about it (We still do it on the URL bar though). I do have a test that fails consistently that works now.
The text was updated successfully, but these errors were encountered: