Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Findbar can get in state of not accepting new chars #5363

Closed
bbondy opened this issue Nov 3, 2016 · 3 comments
Closed

Findbar can get in state of not accepting new chars #5363

bbondy opened this issue Nov 3, 2016 · 3 comments

Comments

@bbondy
Copy link
Member

bbondy commented Nov 3, 2016

I'm not fully sure why it happens but I have a fix. It's something about typing fast when another tab is loading. Also I removed the mixed input controlled type because React gives a warning about it (We still do it on the URL bar though). I do have a test that fails consistently that works now.

@bbondy bbondy added this to the 0.12.8dev milestone Nov 3, 2016
@luixxiul
Copy link
Contributor

luixxiul commented Nov 3, 2016

I noticed it too.

@Sh1d0w
Copy link

Sh1d0w commented Nov 3, 2016

Happened several times to me on latest master as well. Did not open a ticket because I am not sure how exactly to reproduce this.

@bbondy bbondy closed this as completed in d73dd6e Nov 4, 2016
@bbondy
Copy link
Member Author

bbondy commented Nov 4, 2016

Test plan: I could reproduce this by opening the new tab page, then open 2 tabs with command+click, then find in page on the first.
I did find a way to write an automated test that reproduces this with the old code, and it is fixed in the new code.

bbondy added a commit that referenced this issue Nov 4, 2016
This gets rid of the warning that React gives about a controlled component.  It also fixes the problem with when state updates because a background tab changes, it should not re-select text

Fix #5363
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants