Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Opening a context menu freezes video (ex: Youtube) #5470

Closed
jkup opened this issue Nov 7, 2016 · 12 comments · Fixed by brave/muon#161
Closed

Opening a context menu freezes video (ex: Youtube) #5470

jkup opened this issue Nov 7, 2016 · 12 comments · Fixed by brave/muon#161
Assignees
@bsclifton
Labels
feature/context-menu OS/macOS QA/checked-macOS QA/test-plan-specified release-notes/include
Milestone
0.16.13

Comments

@jkup
Copy link
Contributor

jkup commented Nov 7, 2016

Did you search for similar issues before submitting this one?
Yes.

Describe the issue you encountered:
When watching a Youtube video, if you right click the tab it causes the video to freeze.

Expected behavior:

The video should continue to play while right clicking the tab.

  • Platform (Win7, 8, 10? macOS? Linux distro?):

macOS

  • Brave Version:
    0.12.8

  • Steps to reproduce:

    1. Start playing a Youtube video
    2. Right click the Youtube tab (screenshot attached)
    3. See if the video freezes

  • Screenshot if needed:
    screen shot 2016-11-07 at 1 12 59 pm
@jkup jkup added the webcompat label Nov 7, 2016
@srirambv
Copy link
Collaborator

srirambv commented Nov 7, 2016

Same as #3280 ??

@bbondy
Copy link
Member

bbondy commented Nov 8, 2016

Similar but I closed that one since we use about pages now. Context menus are modal for some reason which is really strange currently.

@echosa
Copy link
Contributor

echosa commented Dec 8, 2016

I also recently noticed this behavior. Note that the video's audio continues to play; only the video's image pauses.

@bsclifton
Copy link
Member

bsclifton commented Dec 9, 2016 •
edited
Loading

I believe this is only a problem on macOS; updating label

Some next steps:

  • Understand if macOS offers a non-blocking way to show a popup menu
  • If that is not available, we could convert these to our custom object

@bsclifton bsclifton added needs-investigation A bug not 100% confirmed/fixed that needs QA to better audit. OS/macOS shell-integration Integrating brave with OS-level UI features. and removed webcompat labels Dec 9, 2016
@bsclifton bsclifton changed the title Right clicking tab freezes Youtube video Opening a popup menu freezes video (ex: Youtube) Dec 9, 2016
@luixxiul
Copy link
Contributor

luixxiul commented Jan 4, 2017

We've got another report: https://community.brave.com/t/issue-with-right-click-and-video/528?u=suguru

@luixxiul luixxiul added this to the Backlog milestone Jan 4, 2017
@alexwykoff alexwykoff changed the title Opening a popup menu freezes video (ex: Youtube) Opening a context menu freezes video (ex: Youtube) Feb 6, 2017
@bsclifton
Copy link
Member

We may be able to pull this in: electron/electron#8702

@bsclifton bsclifton self-assigned this Feb 16, 2017
@bsclifton bsclifton modified the milestones: 0.13.6, Backlog Feb 16, 2017
@cndouglas
Copy link

Async context menus would be excellent!

@bbondy
Copy link
Member

bbondy commented Feb 17, 2017

Yes this is really bad right now, we should pull it in.

@echosa
Copy link
Contributor

echosa commented Feb 17, 2017

As a Brave user on Mac, please bring this in as soon as is feasible. This is one of the (currently) ten things on my personal list of "issues with Brave". I would love to see that list dwindle quickly.

bsclifton added a commit to brave/muon that referenced this issue Feb 19, 2017
@bsclifton
Default async to true for popup menus; fix lint errors
2cae00c 
Fixes brave/browser-laptop#5470
@bsclifton bsclifton mentioned this issue Feb 19, 2017
Merged
@luixxiul luixxiul removed needs-investigation A bug not 100% confirmed/fixed that needs QA to better audit. shell-integration Integrating brave with OS-level UI features. labels Feb 19, 2017
bsclifton added a commit to brave/muon that referenced this issue Feb 23, 2017
@bsclifton
Default async to true for popup menus; fix lint errors
c8f3b94 
Fixes brave/browser-laptop#5470
bsclifton added a commit to brave/muon that referenced this issue Feb 28, 2017
@bsclifton
Default async to true for popup menus; fix lint errors
ca5f69b 
Fixes brave/browser-laptop#5470
@bsclifton bsclifton modified the milestones: 0.13.7, 0.13.6 Mar 12, 2017
@alexwykoff alexwykoff mentioned this issue Mar 31, 2017
Closed
82 tasks
@cndouglas cndouglas mentioned this issue Apr 2, 2017
Closed
@bsclifton bsclifton modified the milestones: 0.14.3, 0.14.2 Apr 4, 2017
@bsclifton
Copy link
Member

Moving to 0.14.3

@alexwykoff alexwykoff modified the milestones: 1.1.0, 0.15.1 Apr 18, 2017
@echosa
Copy link
Contributor

echosa commented May 4, 2017

1.1.0? That seems really far away. When I saw this in today's Slack update, it gave me hope for Brave...

screen shot 2017-05-04 at 5 49 51 pm

@bsclifton
Copy link
Member

bsclifton commented May 4, 2017 •
edited
Loading

@echosa tentatively for 1.1.0 😄 I pulled the patch from Electron here:
brave/muon#161

I need some time to troubleshoot problems seen with the code. Hopefully, I (or someone else) can get to it much sooner

bsclifton added a commit to brave/muon that referenced this issue May 9, 2017
@bsclifton
Default async to true for popup menus; fix lint errors
e79d5fb 
Fixes brave/browser-laptop#5470
@bsclifton bsclifton modified the milestones: 0.16.100, 1.1.0 May 23, 2017
bsclifton added a commit to brave/muon that referenced this issue May 24, 2017
@bsclifton
Default async to true for popup menus; fix lint errors
491d264 
Fixes brave/browser-laptop#5470
bsclifton added a commit to brave/muon that referenced this issue May 24, 2017
@bsclifton
Manual application of electron patch electron/electron#8702
d45bf9f 
Additional updates (per electron/electron#8702)

Fixes brave/browser-laptop#5470

- Default `async` to true for popup menus
- fix lint errors
- menus do not destroy themselves
@alexwykoff alexwykoff modified the milestones: 0.16.200, 0.16.100 (Frozen, only critical adds from here) May 30, 2017
@bsclifton bsclifton mentioned this issue Jun 7, 2017
Merged
7 tasks
hferreiro pushed a commit to brave/muon that referenced this issue Jun 29, 2017
@bsclifton @hferreiro
Manual application of electron patch electron/electron#8702
6e0ac92 
Additional updates (per electron/electron#8702)

Fixes brave/browser-laptop#5470

- Default `async` to true for popup menus
- fix lint errors
- menus do not destroy themselves
This was referenced Jul 24, 2017
Closed
Closed
Closed
@bsclifton bsclifton modified the milestones: 0.16.13, 0.18.x Release Jul 27, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bsclifton bsclifton

Labels
feature/context-menu OS/macOS QA/checked-macOS QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.16.13
Development

Successfully merging a pull request may close this issue.

Mac async popup brave/muon
9 participants
@echosa @jkup @bbondy @alexwykoff @luixxiul @bsclifton @srirambv @cndouglas @LaurenWags