Follow-up to #5724: the bravery panel should be much wider

[luixxiul]

Test plan

#10489 (comment)

1. Change the lang setting
2. Restart the browser
3. Open bravery panel on a site
4. Make sure the strings are not wrapped

---

#5724 #5715

on macOS

1. Set your lang setting to Japanese
2. Restart the browser
3. Open https://github.com/brave/browser-laptop/issues/new

The panel should be much wider. It is too small for Japanese, at least.

By setting width: 540px you would get:

I have not tested it on other language settings, so I am not sure if it could work globally.

[luixxiul]

Here is another bug:

the last character is partly hidden.

[srirambv]

This is actually a problem when changed to other languages. For example in Portugese(Brasil), the text is not completely shown and FP and Malware text is all moved to next line.

[luixxiul]

That bug must have existed since the new bravery panel was implemented #1951

[luixxiul]

The issue will be finally fixed with the compact panel:

[srirambv]

Still see issue for Japanese, Russian and Portugese(Brasil)

[luixxiul]

As long as we use the fixed width, that thing can happen.

[luixxiul]

so my conclusion was: make the panel more large, or align the stuff vertically, and I took the latter as the former is not a good one for small monitors.

[bbondy]

Moving to 0.18.x

[srirambv]

This is still an issue on the default shields panel unless we make the narrow panel as default. But for Russian even the narrow panel is as big as the default panel

[luixxiul]

I could set the text-ellipsis to the labels but I didn't because that's the important information and I thought we should not hide them even partially.

@bradleyrichter what do you think on that? Is it OK to set text-ellipsis to the labels?

[bradleyrichter]

Unfortunately we will need to copy-fit the longest strings. @aubrey - do you have a way of requesting max-length strings from translators in the current system?

…

On Jun 21, 2017, at 1:47 AM, Suguru Hirahara ***@***.***> wrote: I could set the text-ellipsis to the labels but I didn't because that's the important information and I thought we should not hide them even partially. @bradleyrichter what do you think on that? Is it OK to set text-ellipsis to the labels? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.