UI issues in Shields menu on master

[srirambv]

Did you search for similar issues before submitting this one?
Yes

Describe the issue you encountered:

1. Ad Control drop down doesn't contain border and is bigger in size compared to Cookie Control drop down
2. Fingerprint Protection is not in same line

• Platform (Win7, 8, 10? macOS? Linux distro?):
  Windows 10 x64

• Brave Version:
  master branch

• Screenshot if needed:
  

• Any related issues:

[bradleyrichter]

I won't sleep until this is fixed! : )

[luixxiul]

1 Ad Control drop down doesn't contain border and is bigger in size compared to Cookie Control drop down

className="form-control" which was introduced 72174bb#diff-e3c84d24d1784f616dac4a76b5d8ef48R290 should have been added to 72174bb#diff-e3c84d24d1784f616dac4a76b5d8ef48R303 too

2 Fingerprint Protection is not in same line

See #1966, I was not sure of a better solution

[luixxiul]

2 Fingerprint Protection is not in same line

See #1966, I was not sure of a better solution

I think the panel of the brave-android version could be one here: list 4 switches vertically rather than place them in a table.

Each text would no longer be wrapped, so it would also be nice from a viewpoint of l10n.

[srirambv]

Works fine for English, but still a problem for other languages. (#5726)
Portugese (Brazil)

PS: The drop down text is not of the same font-size as the rest of them

[luixxiul]

Here's my idea on a compact bravery menu, which would be l10n-friendly.

[srirambv]

Can this layout be only enabled when the text overflows in other languages or when language is changed from English to others?

@bradleyrichter just realized the reload icon is not aligned with text on the current shields panel

[luixxiul]

@srirambv I think it would be possible to enable it globally via an option on the preferences page (though I am not sure how to create the option and switch the two layouts), so that we could hear feedbacks from users.

[luixxiul]

0.12.9

0.12.10 RC1

[srirambv]

The text is getting clipped with the bigger font size in the drop down list

[bradleyrichter]

This must be tied to the button text size? That may be fine but it should be smaller.

On Nov 21, 2016, at 5:17 AM, Sriram Bellur Venkataram notifications@github.com wrote:

The text is getting clipped with the bigger font size in the drop down list

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

[luixxiul]

@bradleyrichter font-size: 14.5px; on 72174bb#diff-57a5fbf005ecc202d1e7e08c11f73b93R10 how small should it be?

[bradleyrichter]

13px

On Nov 21, 2016, at 6:59 AM, Suguru Hirahara notifications@github.com wrote:

@bradleyrichter https://github.com/bradleyrichter font-size: 14.5px; on 72174bb#diff-57a5fbf005ecc202d1e7e08c11f73b93R10 72174bb#diff-57a5fbf005ecc202d1e7e08c11f73b93R10 how small should it be?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub #5715 (comment), or mute the thread https://github.com/notifications/unsubscribe-auth/AM4jqrF1TyFr5Hf3KzIMuM7C369nasWyks5rAbHMgaJpZM4K1WpE.

[alexwykoff]

Label issues covered in #5726

[luixxiul]

Ok done: #5773