Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Coinbase should not be shown in payment modal when bitcoin source is not Coinbase #5788

Closed
srirambv opened this issue Nov 22, 2016 · 1 comment · Fixed by #5924
Closed

Coinbase should not be shown in payment modal when bitcoin source is not Coinbase #5788

srirambv opened this issue Nov 22, 2016 · 1 comment · Fixed by #5924
Assignees
@mrose17
Labels
design A design change, especially one which needs input from the design team. feature/rewards QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.13.0

Comments

@srirambv
Copy link
Collaborator

Did you search for similar issues before submitting this one?
Yes

Describe the issue you encountered:
Coinbase should not be shown in payment modal when bitcoin source is not Coinbase

Expected behavior:
Should show only the bitcoin source in the payment modal
@srirambv srirambv added design A design change, especially one which needs input from the design team. feature/rewards labels Nov 22, 2016
@srirambv srirambv added this to the 1.0.0 milestone Nov 22, 2016
@mrose17 mrose17 self-assigned this Nov 29, 2016
mrose17 added a commit that referenced this issue Nov 30, 2016
@mrose17
initial commit
df2b4c7 
1. Fixes #5788
2. Partially addresses
#4720
3. Needs help for #4114
mrose17 added a commit that referenced this issue Nov 30, 2016
@mrose17
initial check-in
9c33676 
1. Fixes #5788
2. Fixes #4114
3. Partially addresses #4720
@mrose17 mrose17 mentioned this issue Nov 30, 2016
Merged
@cndouglas cndouglas modified the milestones: 0.13.0, 1.0.0 Dec 3, 2016
This was referenced Dec 20, 2016
Closed
Closed
Closed
Closed
@alexwykoff alexwykoff mentioned this issue Dec 20, 2016
Closed
@luixxiul
Copy link
Contributor

Test plan: available in the 1st post

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mrose17 mrose17

Labels
design A design change, especially one which needs input from the design team. feature/rewards QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.13.0
Development

Successfully merging a pull request may close this issue.

initial check-in brave/browser-laptop
4 participants
@mrose17 @luixxiul @srirambv @cndouglas