Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Change download icon to save after torrent is downloaded #5815

Closed
srirambv opened this issue Nov 23, 2016 · 5 comments · Fixed by dcposch/browser-laptop#8
Closed

Change download icon to save after torrent is downloaded #5815

srirambv opened this issue Nov 23, 2016 · 5 comments · Fixed by dcposch/browser-laptop#8
Labels
copy/content/text feature/torrent QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Milestone
0.13.0

Comments

@srirambv
Copy link
Collaborator

Did you search for similar issues before submitting this one?
Yes

Describe the issue you encountered:
Currently torrent download shows the download button even after completing the download

Expected behavior:
Should change the download icon to save button upon completion

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    All

  • Brave Version:
    Master

  • Steps to reproduce:
    1.
    2.
    3.

  • Screenshot if needed:
    image

  • Any related issues:
    cc: @dcposch @feross @bradleyrichter
@srirambv srirambv added design A design change, especially one which needs input from the design team. enhancement feature/extensions suggestion labels Nov 23, 2016
@dcposch
Copy link
Contributor

dcposch commented Nov 29, 2016

How about just changing Download to Save File?

dcposch added a commit to dcposch/browser-laptop that referenced this issue Nov 29, 2016
@dcposch
download -> save file
f1c6bc3 
if the torrent is at 100%, the file is already downloaded, and we're just saving it to the users Downloads folder

fixes brave#5815
@dcposch dcposch mentioned this issue Nov 29, 2016
Merged
dcposch added a commit to dcposch/browser-laptop that referenced this issue Nov 30, 2016
@dcposch
download -> save file
dfc04c8 
if the torrent is at 100%, the file is already downloaded, and we're just saving it to the users Downloads folder

fixes brave#5815
@dcposch dcposch mentioned this issue Nov 30, 2016
Merged
@bbondy bbondy added this to the 0.13.0 milestone Nov 30, 2016
This was referenced Dec 20, 2016
Closed
Closed
Closed
Closed
@luixxiul
Copy link
Contributor

Would anyone please add QA steps for this issue? 0.13.0 will be the largest release ever and the QA team needs clear and simple steps! Please see #6668 for more info. Thanks in advance 🙏

@srirambv
Copy link
Collaborator Author

  • QA Steps
    1. Open any magnet link
    2. Let the torrent start downloading in torrent viewer
    3. In torrent viewer tab, ensure instead of the Download you have Save File

This can only be tested once #5981 is fixed

@luixxiul
Copy link
Contributor

@srirambv do you have an example of the magnet link you use?

@srirambv
Copy link
Collaborator Author

@luixxiul Its mentioned in #5981.
Also pasting it here for reference. Can use any of the magnet links mentioned here https://codepen.io/ferossity/full/qaezaB/

@luixxiul luixxiul added QA/checked-Win32 copy/content/text and removed enhancement feature/extensions design A design change, especially one which needs input from the design team. labels Jan 23, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
copy/content/text feature/torrent QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Projects
None yet
Milestone
0.13.0
Development

Successfully merging a pull request may close this issue.

download -> save file dcposch/browser-laptop
4 participants
@dcposch @bbondy @luixxiul @srirambv