Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

URL bar selects autocomplete result on keypress #5878

Closed
bsclifton opened this issue Nov 28, 2016 · 0 comments
Closed

URL bar selects autocomplete result on keypress #5878

bsclifton opened this issue Nov 28, 2016 · 0 comments

Comments

@bsclifton
Copy link
Member

bsclifton commented Nov 28, 2016

Test plan

#8824 (comment)


Did you search for similar issues before submitting this one?
I only did a quick search, there may already be an issue (help appreciated finding)

Describe the issue you encountered:
Auto-complete results are being chosen when I'm doing a very specific set of key presses when focus is in the URL bar (see steps to repro).

I found this when trying my default logic for copy/paste, which is stupid now that I'm typing it out... but it did uncover this. If you instead use cmd + A to select the contents of the URL bar (instead of what is outlined in step 3), it does work and you can cmd + C it just fine (which is more efficient anyways)

Expected behavior:
Auto-complete result should not be picked unless I use up/down arrow

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    macOS

  • Brave Version:
    0.12.10

  • Steps to reproduce:

    1. Visit https://www.oediscountparts.com/partlocator/index.cfm?siteid=215242
    2. Click inside the URL bar to give it focus and delete the path portion of the URL
      - Hit end (windows) or cmd + right arrow (mac) to move cursor to end
      - hold shift and the modifier key (either ctrl on windows or option on mac) and press left arrow key repeatedly, until you've selected /partlocator/index.cfm?siteid=215242
      - Press delete or backspace to remove that part
    3. Try to select the rest of whats left
      - hold shift + modifier key (cmd / ctrl) and then press left arrow key
      - notice that the first result is auto-selected (which then overrides the URL you had in the box)
  • Screenshot if needed:

  • Any related issues:

bbondy added a commit that referenced this issue May 18, 2017
bbondy added a commit that referenced this issue May 18, 2017
Auditors: @bsclifton

Fix #5878

Test comming in a follow up commit now, just pushing without so you can get a build going
bbondy added a commit that referenced this issue May 18, 2017
bbondy added a commit that referenced this issue May 18, 2017
Auditors: @bsclifton

Fix #5878

Test comming in a follow up commit now, just pushing without so you can get a build going
bbondy added a commit that referenced this issue May 18, 2017
Auditors: @bsclifton

Fix #5878

Test comming in a follow up commit now, just pushing without so you can get a build going
bbondy added a commit that referenced this issue May 18, 2017
bbondy added a commit that referenced this issue May 18, 2017
Auditors: @bsclifton

Fix #5878

Test comming in a follow up commit now, just pushing without so you can get a build going
bbondy added a commit that referenced this issue May 18, 2017
Auditors: @bsclifton

Fix #5878

Test comming in a follow up commit now, just pushing without so you can get a build going
@bsclifton bsclifton added this to the 0.15.300 milestone May 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.