Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Import Bookmark doesn't have any browsers listed except for Chrome #5931

Closed
srirambv opened this issue Nov 30, 2016 · 10 comments
Closed

Import Bookmark doesn't have any browsers listed except for Chrome #5931

srirambv opened this issue Nov 30, 2016 · 10 comments
Assignees
@bridiver
Labels
bug feature/importer QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified regression release-notes/exclude
Milestone
0.13.0

Comments

@srirambv
Copy link
Collaborator

Did you search for similar issues before submitting this one?
Yes

Describe the issue you encountered:
Import Bookmark doesn't have any browsers listed except for Chrome

Expected behavior:
Should show all the available browsers and option to import from HTML file

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Windows 10 x64

  • Brave Version:
    0.13.0 Preview 2

  • Steps to reproduce:

    1. Do a clean install of 0.13.0 preview 2
    2. Click on import browser data from settings
    3. Import modal drop down only has Chrome and nothing else

  • Screenshot if needed:
    image

  • Any related issues:
    cc: @darkdh
@srirambv srirambv added this to the 0.13.0 milestone Nov 30, 2016
@srirambv
Copy link
Collaborator Author

The list shows empty but selecting does import the data.

@darkdh darkdh self-assigned this Nov 30, 2016
@darkdh
Copy link
Member

darkdh commented Dec 1, 2016

I tried 54 with latest commit and it display the list properly
screen shot 2016-12-01 at 10 52 05

@bsclifton
Copy link
Member

Let's retest this when a new release is available 😄

@darkdh darkdh closed this as completed Dec 5, 2016
@darkdh
Copy link
Member

darkdh commented Dec 5, 2016

feel free to reopen if new release does not work

This was referenced Dec 20, 2016
Closed
Closed
Closed
Closed
@luixxiul luixxiul added needs-info Another team member needs information from the PR/issue opener. and removed chromium54 labels Dec 21, 2016
@srirambv
Copy link
Collaborator Author

srirambv commented Dec 21, 2016 •
edited
Loading

Still seeing the same issue on Windows 10 and Windows 7 with 0.13.0 preview 5 build
image

cc: @darkdh @bsclifton

@srirambv srirambv reopened this Dec 21, 2016
@darkdh
Copy link
Member

darkdh commented Dec 21, 2016

This probably related to recent icu changes. I will take a look at it.

@luixxiul luixxiul added regression and removed needs-info Another team member needs information from the PR/issue opener. labels Dec 21, 2016
@darkdh
Copy link
Member

darkdh commented Dec 22, 2016 •
edited
Loading

revert brave/muon@bc050cb and brave/muon@d4f451c will work again. And @bridiver is working on it.

screen shot 2016-12-22 at 16 45 42

@darkdh darkdh assigned bridiver and unassigned darkdh Dec 22, 2016
@bbondy bbondy mentioned this issue Jan 8, 2017
Closed
@darkdh
Copy link
Member

darkdh commented Jan 12, 2017

fixed by brave/muon@fb89355

@darkdh darkdh closed this as completed Jan 12, 2017
@luixxiul
Copy link
Contributor

I added release-notes/exclude as the issue appeared and was fixed within the same milestone.

@luixxiul
Copy link
Contributor

Test plan: available on the 1st post.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bridiver bridiver

Labels
bug feature/importer QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified regression release-notes/exclude
Projects
None yet
Milestone
0.13.0
Development

No branches or pull requests
5 participants
@bridiver @luixxiul @bsclifton @darkdh @srirambv