Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Import bookmark dropdown doesn't list strings properly #6561

Closed
srirambv opened this issue Jan 6, 2017 · 15 comments
Closed

Import bookmark dropdown doesn't list strings properly #6561

srirambv opened this issue Jan 6, 2017 · 15 comments

Comments

@srirambv
Copy link
Collaborator

srirambv commented Jan 6, 2017

Did you search for similar issues before submitting this one?
Yes

Describe the issue you encountered:
Import bookmark dropdown is messed up

Expected behavior:
Should show the drop down properly

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Windows 10 x64

  • Brave Version (revision SHA):

Name Version
Brave 0.13.0
rev 0c7a64d

  • Steps to reproduce:

    1. Launch Brave from command prompt with brave --high-dpi-support=1 --force-device-scale-factor=1
    2. Click on import browser data
    3. Drop down list is messed up
  • Screenshot if needed:
    image

  • Any related issues:
    cc: @bsclifton

@bbondy
Copy link
Member

bbondy commented Jan 8, 2017

Maybe a dupe of #5931 ?

@luixxiul luixxiul added the needs-info Another team member needs information from the PR/issue opener. label Jan 8, 2017
@darkdh
Copy link
Member

darkdh commented Jan 9, 2017

I think @srirambv meant the width of dropdown.

@luixxiul
Copy link
Contributor

luixxiul commented Jan 9, 2017

Though is it because that no browser is listed there?

@srirambv
Copy link
Collaborator Author

srirambv commented Jan 9, 2017

@luixxiul Even though the size of the dropdown is not right I am still able to select the options and import data.

@NejcZdovc
Copy link
Contributor

@srirambv can you paste html of this select element?

@srirambv
Copy link
Collaborator Author

srirambv commented Jan 9, 2017

@NejcZdovc Here's the HTML for the import modal
image

@luixxiul
Copy link
Contributor

luixxiul commented Jan 9, 2017

so Chrome Person 1 should have been displayed

@NejcZdovc
Copy link
Contributor

AFAIK there shouldn't be empty options and yes Chrome Person 1 should be displayed.

@darkdh
Copy link
Member

darkdh commented Jan 9, 2017

empty option is the issue of #5931

@bsclifton
Copy link
Member

bsclifton commented Jan 13, 2017

With both ICU and display fixes in place, we should be able to retest this soon 😄

Building out of browser-laptop-bootstrap on Windows, it works as expected and Chrome Person 1 shows.

@bsclifton bsclifton added release-notes/exclude and removed needs-info Another team member needs information from the PR/issue opener. labels Jan 13, 2017
@darkdh
Copy link
Member

darkdh commented Jan 15, 2017

It looks like this after brave/muon@fb89355 landed
screen shot 2017-01-16 at 00 58 19

@bbondy
Copy link
Member

bbondy commented Jan 15, 2017

but you said you could reproduce with a packaged build locally right?

@bbondy bbondy changed the title Import bookmark dropdown is messed up Import bookmark dropdown doesn't list strings properly Jan 15, 2017
@bbondy
Copy link
Member

bbondy commented Jan 15, 2017

Fix will be in Preview9

@luixxiul
Copy link
Contributor

Test plan:

Launch Brave from command prompt with brave --high-dpi-support=1 --force-device-scale-factor=1
Click on import browser data
Drop down list is NOT messed up

@luixxiul
Copy link
Contributor

Removed OS/Windows as it was not confirmed that the issue was specific to Windows

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants