Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Pref change restart doesn't relaunch the browser #5938

Closed
srirambv opened this issue Nov 30, 2016 · 8 comments
Closed

Pref change restart doesn't relaunch the browser #5938

srirambv opened this issue Nov 30, 2016 · 8 comments
Assignees
@bsclifton
Labels
QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/exclude settings
Milestone
0.13.0

Comments

@srirambv
Copy link
Collaborator

Did you search for similar issues before submitting this one?
Yes

Describe the issue you encountered:
Pref change restart doesn't relaunch the browser

Expected behavior:
Should relaunch the browser when Yes is selected from notification bar

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Windows 10 x64

  • Brave Version:
    0.13.0 Preview 2

  • Steps to reproduce:

    1. Do a clean install of 0.13.0 preview 2
    2. Enable setting which prompts for browser restart
    3. Click on Yes causes the browser to close but doesn't restart on its own

  • Screenshot if needed:

  • Any related issues:
@srirambv srirambv added this to the 0.13.0 milestone Nov 30, 2016
@bsclifton bsclifton self-assigned this Dec 15, 2016
@bsclifton
Copy link
Member

Unable to reproduce this one with 0.13.0 preview 3 or with HEAD (chromium54 on browser-laptop with fresh npm install). I'll close for now, but we should verify (via test plan) that this scenario is covered when next build comes out

@bsclifton bsclifton removed this from the 0.13.0 milestone Dec 15, 2016
@srirambv
Copy link
Collaborator Author

srirambv commented Dec 16, 2016 •
edited
Loading

Able to reproduce this on 0.13.0 Preview 4. Reopening the issue.
5938

@srirambv srirambv reopened this Dec 16, 2016
@luixxiul luixxiul added this to the 0.13.0 milestone Dec 17, 2016
@bridiver
Copy link
Collaborator

@srirambv can you limit the scope of this based on OS? It does not appear to be reproducible on mac

@bsclifton bsclifton assigned bsclifton and unassigned bsclifton Dec 19, 2016
@srirambv
Copy link
Collaborator Author

@bridiver This is on Windows 10 x64. Am able to reproduce this with 0.13.0 Preview 5 as well.

@luixxiul luixxiul mentioned this issue Dec 20, 2016
Closed
@bridiver
Copy link
Collaborator

@srirambv sorry, I read (Win7, 8, 10? macOS? Linux distro?) as something you added, but that is just the default example

@bsclifton
Copy link
Member

bsclifton commented Dec 21, 2016 •
edited
Loading

Reproduced issue

The logs show:

Crash reporting enabled
[5712:744:1220/165126:ERROR:crash_reporter_win.cc(190)] Cannot initialize out-of-process crash handler
null
null

but it doesn't appear to be related AFAIK (it shows up when initially launching)

bsclifton added a commit that referenced this issue Dec 21, 2016
@bsclifton
Fix broken array concat behavior. The + turns it from an array into a…
20d24e9 
… string on Windows (new node behavior?). Definitely wrong.

This fix is to help with #5938

Auditors: @bbondy, @bridiver
@bsclifton bsclifton mentioned this issue Dec 21, 2016
Merged
bsclifton added a commit that referenced this issue Dec 21, 2016
@bsclifton
Fix broken array concat behavior. The + turns it from an array into a…
c2468b9 
… string on Windows (new node behavior?). Definitely wrong.

This fix is to help with #5938

Fixes #6369

Auditors: @bbondy, @bridiver
bsclifton added a commit to brave/muon that referenced this issue Dec 21, 2016
@bsclifton
Fix relaunching on Windows / Linux (unintentionally broke with 7a183f2#…
a201f15 
…diff-854fac274f5ec2e739cc9ca5cea0d445)

Fixes brave/browser-laptop#5938

Auditors: @bridiver, @darkdh
@bsclifton bsclifton mentioned this issue Dec 21, 2016
Merged
@bsclifton
Copy link
Member

Will be fixed by brave/muon#127

I manually tested and it's working great 😄 Hang in there for the next build

This was referenced Dec 30, 2016
Closed
Closed
Closed
Closed
bsclifton added a commit to brave/muon that referenced this issue Dec 30, 2016
@bsclifton
Fix relaunching on Windows / Linux (unintentionally broke with 7a183f2#…
07ef4fb 
…diff-854fac274f5ec2e739cc9ca5cea0d445)

Fixes brave/browser-laptop#5938

Auditors: @bridiver, @darkdh
bbondy pushed a commit to brave/muon that referenced this issue Dec 30, 2016
@bsclifton @bbondy
Fix relaunching on Windows / Linux (unintentionally broke with 7a183f2#…
440867c 
…diff-854fac274f5ec2e739cc9ca5cea0d445)

Fixes brave/browser-laptop#5938

Auditors: @bridiver, @darkdh
@bsclifton bsclifton mentioned this issue Dec 31, 2016
Closed
@luixxiul
Copy link
Contributor

Test plan:

Enable setting which prompts for browser restart
Click "Yes"
The browser is restarted

@srirambv srirambv mentioned this issue Mar 25, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bsclifton bsclifton

Labels
QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/exclude settings
Projects
None yet
Milestone
0.13.0
Development

No branches or pull requests
5 participants
@bridiver @bbondy @luixxiul @bsclifton @srirambv