Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Indicator for drag and drop of bookmarks in bookmarks toolbar #5958

Closed
cndouglas opened this issue Dec 1, 2016 · 4 comments
Closed

Indicator for drag and drop of bookmarks in bookmarks toolbar #5958

cndouglas opened this issue Dec 1, 2016 · 4 comments
Labels
design A design change, especially one which needs input from the design team. duplicate Issue has already been reported feature/bookmarks misc/drag-and-drop

Comments

@cndouglas
Copy link

Did you search for similar issues before submitting this one?
Yes.

Expected behavior:
There needs to be an indicator while dragging and dropping a bookmark in the bookmarks toolbar.

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    All

  • Brave Version:
    0.12.10

  • Steps to reproduce:

    1. Open Brave and show the bookmarks toolbar if necessary.
    2. If necessary, create at least two bookmarks.
    3. Try rearranging the bookmarks by dragging and dropping. Notice that there is little indication of where the bookmark will be relocated.
  • Screenshot if needed:
    Here is an example from Firefox:
    image

  • Any related issues:
    Drag and drop on bookmark manager (trying to manually sort) is broken / unintuitive #5589 (Drag and drop in the Bookmarks Manager)

@bsclifton
Copy link
Member

This would be a great one! The bookmarks manager has a few visual indicators, like showing an open folder icon when dragged over a folder. Would be great to see that vertical bar where it will be positioned if you let go too

@bbondy
Copy link
Member

bbondy commented Dec 8, 2016

It used to make a gap where it would be dropped but that seems to have regressed at some point. This method sounds fine to me.

@bsclifton
Copy link
Member

bsclifton commented Dec 8, 2016

@bbondy that is correct (and is captured with #6033). I investigated and found where it broke, but did not find the root cause (yet)

Additionally adding the vertical bar would be cool, IMO 😄

@bsclifton
Copy link
Member

Closing as duplicate of #6245

@bsclifton bsclifton added the duplicate Issue has already been reported label Apr 19, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
design A design change, especially one which needs input from the design team. duplicate Issue has already been reported feature/bookmarks misc/drag-and-drop
Projects
None yet
Development

No branches or pull requests

3 participants