Dragging tabs no longer shows tabs physically moving

[bsclifton]

Did you search for similar issues before submitting this one?
YEs

Describe the issue you encountered:
Tabs used to show an animation of the surrounding tabs moving out of the way:

Somewhere along the way, this regressed.
Per @bradleyrichter:
This was in 0.12.1 and it fell off shortly after that. By 0.12.5 it was gone

Expected behavior:
Should behave as they do in the picture

• Platform (Win7, 8, 10? macOS? Linux distro?):

• Brave Version: 0.12.5+

• Steps to reproduce:

  1. Drag tab over another tab
  2. Expect to see tabs move out of the way, so you know where it'll be placed
  3. Be disappointed ☹️

[bsclifton]

I narrowed it down; great memory, @bradleyrichter 😄

• This behavior was present in 0.12.1 (f51a293)

• This behavior was broken by 0.12.2 RC1 (dfe352c)

(any help narrowing it down further is appreciated!)

[NejcZdovc]

I tried to reproduce this on my computer, but when I went back in time I get the following error:

Module version mismatch. Expected 50, got 49

I tried with node rebuild to version 1.4, which solved this problem, but tabs were not behaving as are on your screenshot in version 0.12.1 (f51a293). I don't know if this is because of rebuild or something else.

[bsclifton]

@NejcZdovc interesting- did you clear your node_modules and redo the npm install?

I was able to narrow down the above not by using source, but by downloading/installing releases (and working off the commits tied to them)

[NejcZdovc]

@bsclifton yes I deleted my node_modules even electron folder, clean install and even clean pull, but I always get this error. When I switched back to the master branch and run npm_install everything was working correctly out of the box.

I am using node version 7.2.0 and npm version 4.0.3. I would expect that I would get a different error something like expected 50, got 52, because I was going back to September. But it's the other way around which is strange.

[NejcZdovc]

I would love to tackle this problem, but I need to make it work first somehow 😃

[bsclifton]

You may try installing an older version of node.js; I believe back then, we were using version 6.3. Because building our fork of electron involves compiling node.js, it may need to be on the same version (although, it shouldn't matter for this; since it should be using pre-built)

[NejcZdovc]

Will try with node version switcher to set it to 6.3, hope this will help

[jonathansampson]

This was recently mentioned on Twitter by a user:

Rearranging pinned tabs feels weird, like they're not really moving. Chrome's animations are a good feedback as I'm dragging them that something is happening. With Brave I just have to trust that letting go will drop the pinned tab where I want it.
https://twitter.com/jamonholmgren/status/821984857232281600

Dragging tabs in 0.13.0 (Preview 9)

[bsclifton]

@NejcZdovc I know it's been a while- did you want to check this one out?

[luixxiul]

It seems that it does not work as it should

the tab should be dropped to where 🚫 is displayed.

Also we don't need to have this one:

[luixxiul]

I created the issue as a follow up: #6863

[NejcZdovc]

@luixxiul regarding the second one (space around active tab) I already talked with @bradleyrichter and I will remove it when I will be working on tab animations

[luixxiul]

Sweet!