Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fixed dnd for tabs #6809

Merged
merged 1 commit into from
Jan 22, 2017
Merged

Fixed dnd for tabs #6809

merged 1 commit into from
Jan 22, 2017

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Jan 22, 2017 •
edited
Loading

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Resolves #6033

Auditors

@bsclifton

Test Plan

@NejcZdovc
Fixed dnd for tabs
2241a04 
Resolves brave#6033

Auditors: @bsclifton

Test Plan:
- try dnd tabs as mentioned in brave#6033
@NejcZdovc NejcZdovc self-assigned this Jan 22, 2017
@NejcZdovc NejcZdovc requested a review from bsclifton January 22, 2017 11:43
@luixxiul luixxiul added this to the 0.13.1 milestone Jan 22, 2017
@bbondy bbondy modified the milestones: 0.13.0, 0.13.1 Jan 22, 2017
@bbondy
Copy link
Member

bbondy commented Jan 22, 2017

Oh I'm so happy to see this! Thanks for fixing. We'll include it in 0.13.0.

@bbondy bbondy merged commit e642b2d into brave:master Jan 22, 2017
@bsclifton
Copy link
Member

Huge ++! 😄 Thanks so much

@bsclifton
Copy link
Member

@NejcZdovc @bbondy @bradleyrichter quick heads up-

This fix ALSO fixes drag and drop behavior for bookmarks toolbar 😄 The items move out of the way nicely. Super nice fix 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bsclifton bsclifton Awaiting requested review from bsclifton

Assignees

@NejcZdovc NejcZdovc

Labels
feature/tabsbar misc/drag-and-drop
Projects
None yet
Milestone
0.13.0
Development

Successfully merging this pull request may close these issues.
4 participants
@NejcZdovc @bbondy @bsclifton @luixxiul