Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Bookmark dialog looks too skinny #6036

Closed
jkup opened this issue Dec 6, 2016 · 4 comments
Closed

Bookmark dialog looks too skinny #6036

jkup opened this issue Dec 6, 2016 · 4 comments
Assignees
@bradleyrichter
Labels
design A design change, especially one which needs input from the design team. QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Milestone
0.13.0

Comments

@jkup
Copy link
Contributor

jkup commented Dec 6, 2016

Did you search for similar issues before submitting this one?
Yes.

Describe the issue you encountered:
Perhaps related to the recent button refactor the bookmark dialog looks too skinny.

Expected behavior:
It should be wider, maybe around 300px?

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    macOS

  • Brave Version:
    master

  • Steps to reproduce:

    1. Open Brave
    2. Click Bookmark star
    3. See how skinny it is :)

  • Screenshot if needed:

What it used to look like:

screen shot 2016-12-05 at 5 21 38 pm

What it looks like now:
screen shot 2016-12-05 at 5 21 53 pm

  • Any related issues:

@bradleyrichter assuming this is a bug I'll happily take it. Can you just decide and assign to me? Thanks!
@jkup jkup added the design A design change, especially one which needs input from the design team. label Dec 6, 2016
@bradleyrichter
Copy link
Contributor

I think #6000 fixes this...

@luixxiul
Copy link
Contributor

luixxiul commented Dec 6, 2016

Also the button alignment issue has been fixed with 1df8dc3 of the same PR.

@bsclifton
Copy link
Member

Confirmed this was fixed with #6000
screen shot 2016-12-06 at 11 15 18 pm

@bsclifton bsclifton added this to the 0.13.0 milestone Dec 7, 2016
This was referenced Dec 20, 2016
Closed
Closed
Closed
Closed
@alexwykoff alexwykoff mentioned this issue Dec 20, 2016
Closed
@luixxiul
Copy link
Contributor

Test plan: #6000 (comment)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bradleyrichter bradleyrichter

Labels
design A design change, especially one which needs input from the design team. QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Projects
None yet
Milestone
0.13.0
Development

No branches or pull requests
5 participants
@jkup @luixxiul @bsclifton @bradleyrichter @srirambv