This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Button tweak prefs font nicer #6000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
on about:about,
|
luixxiul
force-pushed
the
button-tweak-prefs-font-nicer
branch
from
339ec89 to
44433c7
Compare
|
44433c7 should fixes the bookmark dialog into these:
CC @bsclifton with @bradleyrichter I have added the |
Closes #6004 Auditors: @bradleyrichter Test Plan:
luixxiul
force-pushed
the
button-tweak-prefs-font-nicer
branch
from
1a3cac6 to
1df8dc3
Compare
|
with 1df8dc3
The button size becomes static, regardless of the width of the dialog. |
luixxiul
referenced
this pull request
Dec 3, 2016
- Removed redundant classes from bookmarkButtons to fix the size difference between "Remove" and "Done" buttons, which was introduced with the commit 85e428a - Introduced new classes "removeButton" and "doneButton" inside bookmarkButtons to make the width of the row same as the other rows - Introduced a new class "copyButton" to keep the font-size of the recovery key copy buttons to 14px - Indroduced a flexbox to copyKeyContainer to keep the buttons aligned Auditors: @bradleyrichter Test Plan: 1. Click the bookmark button on the URL bar 2. Make sure height of "Remove" and "Done" buttons is equal 3. Make sure "Remove" button is longer than "Done" button 4. Make sure color of "Remove" label is no longer white on hover 5. Make sure width of the row of the buttons is equal to the other rows 6. Open about:bookmarks and edit a bookmark 7. Make sure height and width of "Remove" and "Done" are equal 8. Open about:preferences#payments, click Advanced Settings and Backup your wallet 9. Make sure keys and buttons are aligned 10. Make sure font-size of the labels "Copy" is 14px
4 tasks
|
++ |
This was referenced Dec 20, 2016
This was referenced Dec 24, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
auditors:
@bbondy
@luixxiul
@jkup
Please check on windows and with Japanese.
This closes #6003
#5916