Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Setting min-width for buttons (l10n-friendly) #6384

Closed
luixxiul opened this issue Dec 22, 2016 · 2 comments
Closed

Setting min-width for buttons (l10n-friendly) #6384

luixxiul opened this issue Dec 22, 2016 · 2 comments

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Dec 22, 2016

Did you search for similar issues before submitting this one?

Describe the issue you encountered:
From a perspective of localization the min-width of the buttons should be specified to avoid the case like this:

screenshot 2016-12-22 13 53 02

Expected behavior:
CC @bradleyrichter for thought

These are almost all of the buttons that should be considered (courtesy of @srirambv) #6372

Please exclude the buttons on the Add funds dialog.

0.13.0 vs 0.12.15
image
image

@luixxiul luixxiul added this to the 0.13.1 milestone Dec 22, 2016
@bradleyrichter
Copy link
Contributor

bradleyrichter commented Dec 22, 2016

I think it is perfectly logical to set a min width for buttons.

6 characters plus padding is a good measurement:
image

@luixxiul
Copy link
Contributor Author

Test Plan:

  1. Open about:autofill
  2. Click "Add Address"
  3. Make sure the width of the button "Cancel" and "Save" is equal

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants