Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Make buttons alignment consistent across different modals #6372

Closed
srirambv opened this issue Dec 21, 2016 · 2 comments
Closed

Make buttons alignment consistent across different modals #6372

srirambv opened this issue Dec 21, 2016 · 2 comments
Assignees
Labels
design A design change, especially one which needs input from the design team. misc/button polish Nice to have — usually related to front-end/visual tasks. QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified refactoring/aphrodite release-notes/include

Comments

@srirambv
Copy link
Collaborator

srirambv commented Dec 21, 2016

Test plan

See #8666

Original issue description

Did you search for similar issues before submitting this one?
Yes

Describe the issue you encountered:
Recovery wallet modal button position is wrong compared to other modals (existing in 0.12.xx builds)
Add Address/Credit card details modal, Save button is not aligned with the input fields (existing in 0.12.xx builds)
Create/Edit bookmark modal Done button is not aligned with the input fields & drop down list (existing in 0.12.xx builds)
Buttons on Edit bookmark modal from URL bar looks weird with right alignment
Import browser data modal buttons are right aligned which is way off with the text
Advance settings modal buttons are on the right looks fine due to the size of modal itself (the only exception where it is fine)

Expected behavior:
Keep all buttons center aligned to keep it consistent across all modals

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Windows 10 x64

  • Brave Version (revision SHA):
    0.12.15 & 0.13.0

  • Steps to reproduce:
    See below comparison between 0.12.15 and 0.13.0

  • Screenshot if needed:
    0.13.0 vs 0.12.15
    image
    image

  • Any related issues:
    cc: @bradleyrichter

@srirambv srirambv added design A design change, especially one which needs input from the design team. feature/autofill feature/bookmarks feature/rewards misc/button polish Nice to have — usually related to front-end/visual tasks. labels Dec 21, 2016
@luixxiul luixxiul added the needs-info Another team member needs information from the PR/issue opener. label Dec 22, 2016
@bsclifton
Copy link
Member

bsclifton commented Dec 28, 2016

Removed some labels- this is more of an overall "application look and feel" issue (not specific to bookmarks or ledger). It would be nice to resolve this as an example in our about:styles screen

cc: @jkup @bradleyrichter

@luixxiul luixxiul self-assigned this Apr 25, 2017
@luixxiul
Copy link
Contributor

Lately most inconsistency have been fixed with #8443. The remaining one is that on add funds modal dialog. I'm working on it, including the sync dialog on #8044

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
design A design change, especially one which needs input from the design team. misc/button polish Nice to have — usually related to front-end/visual tasks. QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified refactoring/aphrodite release-notes/include
Projects
None yet
Development

No branches or pull requests

4 participants