Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Show more details on secure connections #6157

Closed
srirambv opened this issue Dec 12, 2016 · 9 comments · Fixed by #7319
Closed

Show more details on secure connections #6157

srirambv opened this issue Dec 12, 2016 · 9 comments · Fixed by #7319

Comments

@srirambv
Copy link
Collaborator

srirambv commented Dec 12, 2016

Test plan

#7319 (comment)


From support

Clicking the lock just gives a relatively less-than-useful "Secure connection / This page was loaded securely over HTTPS." message. There is no information about protocol details such as cipher choice or CA

Similar to #791
cc: @diracdeltas

@srirambv srirambv added this to the Backlog milestone Dec 12, 2016
@cndouglas
Copy link

Related: #1248 and #2611

@lewellyn
Copy link

I'm the one who had filed the support request, as it wasn't obvious that there was a Github issue tracker for public discussion of things like this. :)

Note that this is orthogonal to #1248 and #2611. I really like the idea of a simplified security check from clicking the lock. It's just currently, well, too simple. 😆

I can envision something like:

🔒 Secure connection
This page was loaded securely over HTTPS, using TLS v1.2.

The security certificate was issued by FooBarBazQuux.
The owner of the site is Spacely Space Sprockets, Inc.

The last line would be for OV/EV certs (with the text in green for EV, probably, to meet user expectations). I personally don't see value in displaying the CN of a DV cert because that starts leading into problems with SANs and such; if there's a domain mismatch, it won't be a valid cert... No reason to overwhelm the average user with redundant information which can only add uncertainty. ("So example.com has a certificate for example.com... Does that mean newmailprovider.org might not have one that matches their name? Would that still be secure, or no?")

As an aside, most browsers don't meaningfully differentiate the display of DV and OV certificates to the user. Part of me thinks this is why EV certificates caught on rapidly, as companies would not have been so willing to spend money on EV certs if OV certs got better treatment by browsers. As individuals cannot obtain EV certificates (in any useful sense), this would also help to make OV certificates worthwhile for individuals to purchase.

While there is the obvious enhancement of a "More Info" link which opens the Developer Tools panel, I've purposely omitted it: if a developer is looking for an overview of the connection ("Is this site now using the certificate I think it is? Or is it the one from the old CA which expires next week?" or "Did enabling TLS 1.2 work?"), this seems to be a happy medium of providing the most basic useful information for clueful people while making less-technical users feel confident and not overwhelming them. I, however, acknowledge that common practice is to jump from "simple view" to "OMG ALL THE THINGS!!!!1111". I just don't see the inherent value.

I just went through a number of browsers to see what they do, after writing all of the above, and this method is most similar to Microsoft Edge's. So there's precedent in the general concept, though I expect Brave can make it look much better. 👍

Note that a large concern here is balancing "tell the average user enough that they can feel secure, but not enough to feel out of their league" versus "tell the users who need to know details enough that they can avoid opening the Developer Tools to find out basic information". If done right, it may demystify things enough to even help the average user feel more confident with security certificates and that can only be a good thing. One does not need to be initiated into the inner sanctum to worship at the altar, likewise much complexity can be eliminated as long as there is enough information left to have faith in the connection.

Hopefully this helps illuminate the value I see here, and helps guide the Brave developers towards ending up with a solution which pleases everyone enough that no one complains in the future. 😃

@hexploitable
Copy link

I literally just ditched Chrome because of this exact problem. I'm pretty much all for adopting Brave but this is key to me. To the point where tonight when i get off work i'll literally be looking at the source to see if i can POC this myself.

@bsclifton
Copy link
Member

bsclifton commented Feb 15, 2017

I believe @darkdh is working on this (or something similar). @darkdh, do you have an update?

@hexploitable let us know if you need any help getting set up 😄 Any help is appreciated

@darkdh
Copy link
Member

darkdh commented Feb 16, 2017

There is a WIP branch in muon
https://github.com/brave/muon/tree/view_certificate

@darkdh
Copy link
Member

darkdh commented Feb 16, 2017

And here is the screenshot on Mac
screen shot 2017-02-16 at 23 26 33

@darkdh
Copy link
Member

darkdh commented Feb 16, 2017

dup #2611

@darkdh darkdh closed this as completed Feb 16, 2017
@darkdh darkdh removed this from the Backlog milestone Feb 16, 2017
@hexploitable
Copy link

Actually #2611 isn't a duplicate. #2611 is about the button in dev tools not working. This issue is about showing more details when clicking the padlock in the URL bar.

@bsclifton
Copy link
Member

@hexploitable agreed- I think this is it's own issue. Assigning @darkdh 😄

@bsclifton bsclifton reopened this Feb 16, 2017
darkdh added a commit that referenced this issue Feb 20, 2017
Hide view certificate button until muon support linux

fix #6157

Auditors: @bridiver, @bbondy
darkdh added a commit that referenced this issue Mar 13, 2017
Hide view certificate button until muon support linux

fix #6157

Auditors: @bridiver, @bbondy
bsclifton pushed a commit that referenced this issue Mar 24, 2017
Hide view certificate button until muon support linux

fix #6157

Auditors: @bridiver, @bbondy
@luixxiul luixxiul added this to the 0.14.0 milestone Mar 24, 2017
@alexwykoff alexwykoff changed the title Show more details on secure connections Added more details on secure connections Mar 28, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.