Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Tabs.create isn't actually creating a tab #6159

Closed
bbondy opened this issue Dec 12, 2016 · 1 comment
Closed

Tabs.create isn't actually creating a tab #6159

bbondy opened this issue Dec 12, 2016 · 1 comment
Assignees
@bridiver
Labels
feature/rewards QA/no-qa-needed release-notes/include
Milestone
0.13.0

Comments

@bbondy
Copy link
Member

bbondy commented Dec 12, 2016

Currently isn't actually creating a new tab. I think this fails the pocket test and also causes webContents.print inside ledger to not print backup keys.
@bbondy bbondy added this to the 0.13.0 milestone Dec 12, 2016
@bbondy bbondy changed the title Tabs.create isn't working Tabs.create isn't actually creating a tab Dec 12, 2016
bbondy added a commit that referenced this issue Dec 12, 2016
@bbondy
Fix call to Tabs.create when printing backup recovery keys
492bc95 
Fix #6150

Auditors: @bsclifton

It was crashing because it was treating this api as a promise but really it uses callbacks.

Note that the print operation won't actually work until #6159 is addressed.
@bbondy bbondy mentioned this issue Dec 12, 2016
Closed
@darkdh darkdh assigned darkdh and bridiver and unassigned darkdh Dec 12, 2016
bridiver pushed a commit that referenced this issue Dec 14, 2016
@bbondy @bridiver
Fix call to Tabs.create when printing backup recovery keys
79362d3 
Fix #6150

Auditors: @bsclifton

It was crashing because it was treating this api as a promise but really it uses callbacks.

Note that the print operation won't actually work until #6159 is addressed.
@bbondy
Copy link
Member Author

bbondy commented Dec 15, 2016

Fixed by 52c12cb

@bbondy bbondy closed this as completed Dec 15, 2016
bbondy referenced this issue Dec 15, 2016
@bridiver
use extensions.createTab for tabs.create
52c12cb 
auditors: @bbondy
This was referenced Dec 20, 2016
Closed
Closed
Closed
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bridiver bridiver

Labels
feature/rewards QA/no-qa-needed release-notes/include
Projects
None yet
Milestone
0.13.0
Development

No branches or pull requests
4 participants
@bridiver @bbondy @luixxiul @darkdh