This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Merge 'reportAnIssue' and 'submitFeedback' #6180

Closed

luixxiul opened this issue Dec 13, 2016 · 9 comments

Assignees

Labels

bug/good-first-bug copy/content/text QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/include settings

Milestone

Contributor

luixxiul commented Dec 13, 2016 •

edited

Loading

#6080 (comment) Merge 'reportAnIssue' and 'submitFeedback'

Brave Version: master branch
Any related issues: "Submit Feedback..." link to use community.brave.com #6179

Test plan:
Ensure Report an Issue no longer shows up in the Help menu

cndouglas added the copy/content/text label

luixxiul added the settings label

luixxiul added the bug/good-first-bug label

luixxiul added this to the contributor backlog milestone

Contributor

bkilrain commented Jan 2, 2017

I'm really interested in getting some more open source contributions under my belt and I'm especially interested in Brave. Would it be ok if I gave this one a shot? I've already checked out the codebase...

Member

bsclifton commented Jan 2, 2017

@bkilrain absolutely 😄 I'll assign it to myself, but please give it a shot. Let us know if you have any questions

bsclifton self-assigned this

bkilrain added a commit to bkilrain/browser-laptop that referenced this issue


          Merge "reportAnIssueMenuItem" and "submitFeedbackMenuItem"

cd4af19

Deletes "Report an Issue" menu item because both it and "Submit Feedback"
link to community.brave.com.

Resolves brave#6180

Contributor

bkilrain commented Jan 2, 2017

Ok - I just removed 'reportAnIssueMenuItem' from the codebase since it functioned exactly like 'submitFeedbackMenuItem'. I'm not sure if that was the order of the day. Also, I didn't write any tests since there aren't tests for the other menu items. If something else is needs doing, or I misinterpreted the issue comments, let me know. @bsclifton

bkilrain mentioned this issue

Merge "reportAnIssueMenuItem" and "submitFeedbackMenuItem" #6499

Merged

4 tasks

Contributor Author

luixxiul commented Jan 2, 2017

@bkilrain please see: #6080 (comment)

Also you would have to merge reportAnIssue and submitFeedback in /app/locale.js and /app/extensions/brave/locales/en-US/menu.properties.

Contributor

bkilrain commented Jan 2, 2017

Ahh - good catch @luixxiul... thanks.

Re: the comment you referenced - would you rather I added deep links to those menu items or is just linking to community.brave.com sufficient for submitFeedback?

bkilrain added a commit to bkilrain/browser-laptop that referenced this issue


          Remove all references to ReportAnIssueMenuItem

131e4fd

Resolves brave#6180
Auditors:

Test Plan:

Contributor

bkilrain commented Jan 5, 2017

@luixxiul @bsclifton just bumping this back on your radar. I know it's small potatoes but wondering if there is anything else I need to do to resolve this issue and get onto the next one. As I'm new-ish to open source contributions, any feedback would be greatly appreciated as well. 👍

luixxiul modified the milestones: 0.13.1, contributor backlog

Contributor Author

luixxiul commented Jan 5, 2017 •

edited

Loading

Setting the milestone to 0.13.1 as it will be released after ~one month when the link to zendesk was replaced with that to the community.

cndouglas commented Jan 12, 2017

There's a comment on the PR: #6499 (comment)

Member

bsclifton commented Jan 12, 2017

Fixed with #6499 which was merged into branch 0.13.1-branch.

bsclifton closed this as completed

bsclifton pushed a commit that referenced this issue


          Merge "reportAnIssueMenuItem" and "submitFeedbackMenuItem"

6756cfa

Deletes "Report an Issue" menu item because both it and "Submit Feedback"
link to community.brave.com.

Resolves #6180

bsclifton pushed a commit that referenced this issue


          Remove all references to ReportAnIssueMenuItem

7d7917d

Resolves #6180
Auditors:

Test Plan:

bsclifton pushed a commit that referenced this issue


          Merge "reportAnIssueMenuItem" and "submitFeedbackMenuItem"

6a0fa64

Deletes "Report an Issue" menu item because both it and "Submit Feedback"
link to community.brave.com.

Resolves #6180

bsclifton pushed a commit that referenced this issue


          Remove all references to ReportAnIssueMenuItem

f41f623

Resolves #6180
Auditors:

Test Plan:

bsclifton pushed a commit that referenced this issue


          Merge "reportAnIssueMenuItem" and "submitFeedbackMenuItem"

bf5c792

Deletes "Report an Issue" menu item because both it and "Submit Feedback"
link to community.brave.com.

Resolves #6180

bsclifton pushed a commit that referenced this issue


          Remove all references to ReportAnIssueMenuItem

610e6dd

Resolves #6180
Auditors:

Test Plan:

luixxiul added QA/test-plan-specified release-notes/include labels

bsclifton pushed a commit that referenced this issue


          Merge "reportAnIssueMenuItem" and "submitFeedbackMenuItem"

33ffe66

Deletes "Report an Issue" menu item because both it and "Submit Feedback"
link to community.brave.com.

Resolves #6180

bsclifton pushed a commit that referenced this issue


          Remove all references to ReportAnIssueMenuItem

6f688d9

Resolves #6180
Auditors:

Test Plan:

bsclifton pushed a commit that referenced this issue


          Merge "reportAnIssueMenuItem" and "submitFeedbackMenuItem"

3a39fa2

Deletes "Report an Issue" menu item because both it and "Submit Feedback"
link to community.brave.com.

Resolves #6180

bsclifton pushed a commit that referenced this issue


          Remove all references to ReportAnIssueMenuItem

240c586

Resolves #6180
Auditors:

Test Plan:

bkilrain added a commit to bkilrain/browser-laptop that referenced this issue


          Merge "reportAnIssueMenuItem" and "submitFeedbackMenuItem"

4d9f618

Deletes "Report an Issue" menu item because both it and "Submit Feedback"
link to community.brave.com.

Resolves brave#6180

bkilrain added a commit to bkilrain/browser-laptop that referenced this issue


          Remove all references to ReportAnIssueMenuItem

596e8aa

Resolves brave#6180
Auditors:

Test Plan:

NejcZdovc pushed a commit to NejcZdovc/browser-laptop that referenced this issue


          Merge "reportAnIssueMenuItem" and "submitFeedbackMenuItem"

acde896

Deletes "Report an Issue" menu item because both it and "Submit Feedback"
link to community.brave.com.

Resolves brave#6180

NejcZdovc pushed a commit to NejcZdovc/browser-laptop that referenced this issue


          Remove all references to ReportAnIssueMenuItem

10851d7

Resolves brave#6180
Auditors:

Test Plan:

bsclifton pushed a commit that referenced this issue


          Merge "reportAnIssueMenuItem" and "submitFeedbackMenuItem"

b59739f

Deletes "Report an Issue" menu item because both it and "Submit Feedback"
link to community.brave.com.

Resolves #6180

bsclifton pushed a commit that referenced this issue


          Remove all references to ReportAnIssueMenuItem

2d8cb9d

Resolves #6180
Auditors:

Test Plan:

bsclifton pushed a commit that referenced this issue


          Merge "reportAnIssueMenuItem" and "submitFeedbackMenuItem"

80fb4cd

Deletes "Report an Issue" menu item because both it and "Submit Feedback"
link to community.brave.com.

Resolves #6180

bsclifton pushed a commit that referenced this issue


          Remove all references to ReportAnIssueMenuItem

d70b72c

Resolves #6180
Auditors:

Test Plan:

bsclifton pushed a commit that referenced this issue


          Merge "reportAnIssueMenuItem" and "submitFeedbackMenuItem"

aa6a948

Deletes "Report an Issue" menu item because both it and "Submit Feedback"
link to community.brave.com.

Resolves #6180

bsclifton pushed a commit that referenced this issue


          Remove all references to ReportAnIssueMenuItem

7fdc244

Resolves #6180
Auditors:

Test Plan:

bsclifton pushed a commit that referenced this issue


          Merge "reportAnIssueMenuItem" and "submitFeedbackMenuItem"

71db614

Deletes "Report an Issue" menu item because both it and "Submit Feedback"
link to community.brave.com.

Resolves #6180

bsclifton pushed a commit that referenced this issue


          Remove all references to ReportAnIssueMenuItem

c298b12

Resolves #6180
Auditors:

Test Plan:

This was referenced Feb 3, 2017

Manual Tests for Windows x64 0.13.2 RC2 #7030

Closed

Manual Tests for Windows ia-32 0.13.2 RC3 #7029

Closed

Manual Tests for Linux 0.13.2 RC3 #7028

Closed

Manual Tests for OS X 0.13.2 RC2 #7027

Closed

bbondy added the QA/checked-macOS label

aekeus added the QA/checked-Linux label

luixxiul added the QA/checked-Win32 label

srirambv added the QA/checked-Win64 label

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.