Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Selected text in text fields is missing Look Up in context menu (macOS-only) #6536

Closed
cndouglas opened this issue Jan 5, 2017 · 2 comments
Closed

Comments

@cndouglas
Copy link

Did you search for similar issues before submitting this one?
Yes.

Describe the issue you encountered:
When right-clicking selected text in a text field on macOS, the Look Up option (dictionary definition) is not shown.

Expected behavior:
The Look Up option should be shown for selected text, as it is with normal text.

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    macOS 10.12.x

  • Brave Version (revision SHA):
    0.12.15

  • Steps to reproduce:

    1. Open a new Brave tab and navigate to any site with a text field.
    2. Activate the text field and type some text.
    3. Select the text.
    4. Right-click.
    5. Notice that there is no Look Up option.
  • Screenshot if needed:
    image

  • Any related issues:
    None.

@cndouglas cndouglas self-assigned this Jan 5, 2017
@cndouglas cndouglas changed the title Selected text in text fields is missing Look Up in context menu Selected text in text fields is missing Look Up in context menu (macOS-only) Jan 5, 2017
@bsclifton
Copy link
Member

bsclifton commented Jan 13, 2017

Fixed with #6545 which was merged into branch 0.13.1-branch.

Test Plan

  1. Open a new Brave tab and navigate to any site with a text field.
  2. Activate the text field and type some text.
  3. Select the text.
  4. Right-click.
  5. Click the Look Up… option.
  6. Make sure the definition is shown for the selected text.

@bsclifton bsclifton added this to the 0.13.1 milestone Jan 13, 2017
bsclifton pushed a commit that referenced this issue Jan 14, 2017
bsclifton pushed a commit that referenced this issue Jan 17, 2017
bsclifton pushed a commit that referenced this issue Jan 17, 2017
bsclifton pushed a commit that referenced this issue Jan 18, 2017
bsclifton pushed a commit that referenced this issue Jan 20, 2017
NejcZdovc pushed a commit to NejcZdovc/browser-laptop that referenced this issue Jan 23, 2017
bsclifton pushed a commit that referenced this issue Jan 23, 2017
bsclifton pushed a commit that referenced this issue Jan 24, 2017
bsclifton pushed a commit that referenced this issue Jan 25, 2017
bsclifton pushed a commit that referenced this issue Jan 25, 2017
@bbondy
Copy link
Member

bbondy commented Feb 3, 2017

This isn't working consistently for me, I posted a follow up for it here:
#7043

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants