This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Add close tab settings #6553

Closed

bbondy opened this issue Jan 6, 2017 · 8 comments

Assignees

Labels

feature/tabsbar QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/include settings

Milestone

Member

bbondy commented Jan 6, 2017

It would be nice to provide options for what to do when a tab is closed. Currently we will return to the parent tab first, and if no parent go to the next.

Cross posting from community.brave.com:

Normally these are the possibilities when we close an active tab.

1.Activate the last active tab
The default setting returns focus to the most recently used tab
2.Activate the next tab
This setting returns focus to the next tab on the tab bar
3.Activate first tab 
But I don't see a preference setting like these in the "Tab Setting" section. This would be a nice addition.

Reference:
https://community.brave.com/t/tab-focus-when-an-active-tab-is-closed-if-there-are-multiple-tabs-open/540

The text was updated successfully, but these errors were encountered:

bsclifton added settings feature/tabsbar labels

Contributor

NejcZdovc commented Jan 7, 2017

@bbondy can I tackle this issue?

NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue


          Added close tab settings

3e999a0

Resolves brave#6553

Auditors: @bbondy @bsclifton

Test Plan:
- Go to Preferences and set desired action
- Close tab
- New active tab should opened as defined in preferences

NejcZdovc mentioned this issue

Close tab settings #6573

Merged

4 tasks

Contributor

luixxiul commented Jan 8, 2017 •

edited

Loading

There are other options to be added later: #2137

Contributor

NejcZdovc commented Jan 8, 2017 •

edited

Loading

@luixxiul Do you think that they should be part of this PR? I can add them is separate PR's. Or are you talking about close tab options directly, I didn't find anything related to them?

Contributor

luixxiul commented Jan 8, 2017

@NejcZdovc No I don't think so, I just related them for references ;-)

Contributor

luixxiul commented Jan 8, 2017 •

edited

Loading

Oh, this PR (#6573) implements the setting of closing tabs, while in #2137 the setting of opening new tabs is suggested. If this function can be implemented in a similar way, I think you're the proper person to implement it 👍 if you don't mind. @NejcZdovc

If you will add it, I could help designing the tab settings panel to close #2137 before 1.0 :D

Contributor

NejcZdovc commented Jan 8, 2017

Sure will implement after this closing tab PR.

NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue


          Added close tab settings

94a17be

Resolves brave#6553

Auditors: @bbondy @bsclifton

Test Plan:
- Go to Preferences and set desired action
- Close tab
- New active tab should opened as defined in preferences

NejcZdovc self-assigned this

NejcZdovc mentioned this issue

Tab Settings Panel #2137

Closed

bsclifton pushed a commit to NejcZdovc/browser-laptop that referenced this issue


          Added close tab settings

4cfcd47

Resolves brave#6553

Auditors: @bbondy @bsclifton

Test Plan:
- Go to Preferences and set desired action
- Close tab
- New active tab should opened as defined in preferences

bsclifton added this to the 0.13.1 milestone

NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue


          Added close tab settings

27e7b07

Resolves brave#6553

Auditors: @bbondy @bsclifton

Test Plan:
- Go to Preferences and set desired action
- Close tab
- New active tab should opened as defined in preferences

NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue


          Added close tab settings

e5cba41

Resolves brave#6553

Auditors: @bbondy @bsclifton

Test Plan:
- Go to Preferences and set desired action
- Close tab
- New active tab should opened as defined in preferences

NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue


          Added close tab settings

4835b8b

Resolves brave#6553

Auditors: @bbondy @bsclifton

Test Plan:
- Go to Preferences and set desired action
- Close tab
- New active tab should opened as defined in preferences

bsclifton added a commit that referenced this issue


          Merge pull request #6573 from NejcZdovc/feature/#6553-close-tab-settings

bd9183d

Close tab settings

Contributor

luixxiul commented Jan 23, 2017

#6573 was merged into 0.13.1-branch.

luixxiul closed this as completed

bsclifton pushed a commit that referenced this issue


          Added close tab settings

Resolves #6553

Auditors: @bbondy @bsclifton

Test Plan:
- Go to Preferences and set desired action
- Close tab
- New active tab should opened as defined in preferences

bsclifton pushed a commit that referenced this issue


          Added close tab settings

e90da34

Resolves #6553

Auditors: @bbondy @bsclifton

Test Plan:
- Go to Preferences and set desired action
- Close tab
- New active tab should opened as defined in preferences

ayumi pushed a commit that referenced this issue


          Added close tab settings

2ea86c7

Resolves #6553

Auditors: @bbondy @bsclifton

Test Plan:
- Go to Preferences and set desired action
- Close tab
- New active tab should opened as defined in preferences

ayumi pushed a commit that referenced this issue


          Added close tab settings

b1f35e1

Resolves #6553

Auditors: @bbondy @bsclifton

Test Plan:
- Go to Preferences and set desired action
- Close tab
- New active tab should opened as defined in preferences

bsclifton pushed a commit that referenced this issue


          Added close tab settings

ab4b006

Resolves #6553

Auditors: @bbondy @bsclifton

Test Plan:
- Go to Preferences and set desired action
- Close tab
- New active tab should opened as defined in preferences

bsclifton pushed a commit that referenced this issue


          Added close tab settings

e44809a

Resolves #6553

Auditors: @bbondy @bsclifton

Test Plan:
- Go to Preferences and set desired action
- Close tab
- New active tab should opened as defined in preferences

ayumi pushed a commit that referenced this issue


          Added close tab settings

27070e9

Resolves #6553

Auditors: @bbondy @bsclifton

Test Plan:
- Go to Preferences and set desired action
- Close tab
- New active tab should opened as defined in preferences

ayumi pushed a commit that referenced this issue


          Added close tab settings

cd7e973

Resolves #6553

Auditors: @bbondy @bsclifton

Test Plan:
- Go to Preferences and set desired action
- Close tab
- New active tab should opened as defined in preferences

bsclifton pushed a commit that referenced this issue


          Added close tab settings

3c96b75

Resolves #6553

Auditors: @bbondy @bsclifton

Test Plan:
- Go to Preferences and set desired action
- Close tab
- New active tab should opened as defined in preferences

luixxiul added release-notes/include QA/test-plan-specified labels

NejcZdovc mentioned this issue

Command-click opens tab at far right of window, not adjacent #6907

Closed

This was referenced Feb 3, 2017

Manual Tests for Windows x64 0.13.2 RC2 #7030

Closed

Manual Tests for Windows ia-32 0.13.2 RC3 #7029

Closed

Manual Tests for Linux 0.13.2 RC3 #7028

Closed

Manual Tests for OS X 0.13.2 RC2 #7027

Closed

bbondy added the QA/checked-macOS label

aekeus added the QA/checked-Linux label

luixxiul added the QA/checked-Win32 label

Contributor

luixxiul commented Feb 4, 2017

It works perfectly! I like it :-D

srirambv added the QA/checked-Win64 label

bsclifton mentioned this issue

"Select its parent tab" setting not working as expected #9395

Closed

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.