Sites added manually (auto-suggest sites off) don't show if adv criteria not met

[bsclifton]

Auto-suggest sites (our current Brave Payments tab behavior for including sites) will be introduced with #6422

The user can choose to disable this and instead, they'll be shown the bitcoin icon in the URL bar. Here is the exact problem:

• User clicks bitcoin icon for a site they are not yet supporting
• Icon lights up, signifying they are now supporting the site
• User goes to preferences -> Payments
• Site is NOT shown in the list, because advanced criteria is not met yet
• If page visits or time goes over threshold, site is then shown (as expected) with the correct enabled setting

[bsclifton]

cc: @mrose17 @bradleyrichter

Maybe this behavior is OK? No milestone set since it would be good to discuss

[bsclifton]

A few options to kick things off:

1. Do nothing; we can put a footnote in the Payments tab which states:
*NOTE: sites which don't match criteria shown in "Advanced Settings" are not shown

2. We could always show ALL sites and then disable some of the advanced criteria:

3. We could create and use a "tri-state" bitcoin button that the user would click

• Disabled by default (gray icon)
• Click once to add it to your supported sites (orange icon)
• Click one more time to enable an "always support" mode (new icon)

4. Make clicking the bitcoin button meet the criteria automatically.

• Site gets added to supported sites
• Minimum view count is added, to ensure it shows

[cezaraugusto]

Speaking as a user, I personally prefer to hit the bitCoin icon and just show the site I want on publisher's list immediately, thus skipping current advanced criteria. With no additional settings.

Supposing the below scenario:

I am an avid reader of https://clifton.io, and I'd like to support his site. However he's not publishing much for a while, so I don't visit his website so often, BUT I like him, his blog, and I'd like to send him money anyway.

What I do is just go one time to his website and hit the enabled publisher icon, and now he's on my budget list and I can keep browsing other stuff. Otherwise, I'd have to change rules and browse randomly his blog just to make sure he's on the list, which can be annoying.

[bradleyrichter]

@cezaraugusto As a user, do you expect each site you mark for payment inclusion to share your monthly budget evenly in this case?

Do you expect to be able to set it for an X amount of monthly value?

[cezaraugusto]

yes, that's expected to me. That sites I choose to add share my monthly budget evenly.

I think setting an X amount is valid as well, and very likely to be a feature request from users in a near future.

[cezaraugusto]

Stepping back from this one and tagging @mrose17 in favour of his fix.

[mrose17]

waiting for #6706 to be merged in order to close.

[bsclifton]

Closed with #6706

Test Plan

1. go to about:preferences#payments
2. set auto-suggest sites to off
3. go to a site in another tab
4. click on the BTC icon
5. go back to the first tab and see if the site is present

[luixxiul]

The issue was reopened as the icon is not implemented yet like #6754 (comment)

[cezaraugusto]

for reference: two main problems regarding this issue is that:

• sites added manually only show if you refresh payments panel
• sites added manually don't have icons

[mrose17]

@cezaraugusto - can you close this issue and open a new one with just the two bullet points above?

[cezaraugusto]

Closing in favour of #7111