Fixed "Estimated Time Saved" to take minutes into account

[luixxiul]

Test Plan

1. Launch Brave and visit a few sites which have ads or trackers (http://cnn.com, https://slashdot.org/)
2. Quit Brave. Make sure all instances of Brave are closed
3. Open your session file (~/Libraries/Application Support/brave/session-state-1 on macOS, %appdata%\brave\session-state-1 on Windows) in an editor such as Sublime, vim, notepad, etc. If you have a JSON formatting plugin, you may wish to use it (so that it's easier to edit)
4. Edit the JSON foradblock > count to be 555555 (six fives)
   
5. Save the file and then launch Brave
6. Verify it shows hours with 1 decimal point of precision, like so:
   
7. Close Brave and re-open your session file in your editor of choice
8. Edit the adblock > count value to be 55555555 (eight fives)
9. Save the file and then launch Brave
10. Verify it shows the days with two digits of precision, like so:
    

Original issue description

Describe the issue you encountered:

The new tab page has been displaying Estimated Time Saved 2 hours for some time now.

https://community.brave.com/t/estimated-time-saved-stuck-at-2-hours/735

I noticed it as well.

Expected behavior:

• Platform (Win7, 8, 10? macOS? Linux distro?): macOS

• Brave Version (revision SHA): 0.12.15

• Any related issues:

[darkdh]

I feel the same way

[luixxiul]

I added the milestone to 0.13.1

[bbondy]

How many ads and trackers do you have?

[bbondy]

@bradleyrichter this seems like just a UX issue because the next hour limit isn't attained very easily but people still want to see progress. Removing milestone for now though since I don't believe it to be a bug, but I'd like it to be improved though.

[bradleyrichter]

Heh. We will need add minutes.

…

On Jan 28, 2017, at 11:27 AM, Brian R. Bondy ***@***.***> wrote: @bradleyrichter this seems like just a UX issue because the next hour limit isn't attained very easily but people still want to see progress. Removing milestone for now though since I don't believe it to be a bug, but I'd like it to be improved though. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[bsclifton]

Updated the title 😄 It would be good if (whatever the unit is), the next smallest unit could be used as a decimal. Like 2.5 hours. Truncating it to "2 hours" is definitely confusing and has caught me making faces like 🤔

[bbondy]

Eventually someone will hit days so I think @bsclifton's idea is best, thougths @bradleyrichter ? Just no decimal if it's minutes or smaller.

[bradleyrichter]

i think the hour truncation was just a side effect of the overall truncation and yes, we can special-case hours to use a decimal place. This should solve the problem at hand.

[maazadeeb]

Hi guys,

I would like to take this up. 😄 Correct me if I'm wrong about the expectation

if time < 1 hour
    stay with current behaviour
else if time < 1 day
    show 1 decimal place for hours
else
    show 1 decimal place for days

[bbondy]

sgtm, or even 2 decimal places for days. @bradleyrichter thoughts?

[bradleyrichter]

This will be fine. Thanks!

…

On Feb 5, 2017, at 7:46 AM, Brian R. Bondy ***@***.***> wrote: sgtm, or even 2 decimal places for days. @bradleyrichter thoughts? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[maazadeeb]

Awesome! The final expectation, for future reference:

if time < 1 hour
    stay with current behaviour
else if time < 1 day
    show 1 decimal place for hours
else
    show 2 decimal places for days

[luixxiul]

I thought the fix would be 7 hours 48 minutes with the test case in the 1st post.

To be honest I cannot figure out how long 0.15 day is, if it is not converted to hours and minutes...