Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Added stop button for torrent downloads - there is no obvious way to stop a torrent download once it has started #6768

Closed
bridiver opened this issue Jan 20, 2017 · 2 comments

Comments

@bridiver
Copy link
Collaborator

bridiver commented Jan 20, 2017

Test Plan

#7863 (comment)

  1. Click a torrent or magnet link from this list https://webtorrent.io/free-torrents
  2. Click 'Start Download'. The torrent detail view should appear.
  3. Wait a few seconds, click 'Stop Download'. The torrent start page with a 'Start Download' button should return, indicating the download has stopped.

Original issue description

  • Did you search for similar issues before submitting this one?
    Yes

  • Describe the issue you encountered:
    If you click on a torrent link and start the download, there does not appear to be any way to stop it

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    All

  • Brave Version (revision SHA):
    986387e

  • Steps to reproduce:

    1. go to http://codepen.io/ferossity/full/qaezaB/
    2. Click on any of the torrent links
    3. Start the download
  • Can this issue be consistently reproduced?
    Yes

  • Any related issues:

cc @feross

@bsclifton bsclifton changed the title there is no obvious way to stop a torrent download once it has tarted there is no obvious way to stop a torrent download once it has started Jan 20, 2017
@feross
Copy link
Contributor

feross commented Jan 20, 2017

Closing the tab will stop the download. That means it disconnects from all peers and shuts down the torrent client entirely (if there are no other torrents active).

Our thinking in leaving out a download button was to treat torrents no different than other content that the browser can render, like PDFs, images, and video files. For example, to stop an HTTP video file from downloading, you just close the tab. The only difference with torrents is that we get upfront user consent before starting the download in the first place.

Can folks with design/UX experience take a look at this and suggest improvements?

cc @dcposch

@feross
Copy link
Contributor

feross commented Mar 23, 2017

This is done. PR here: #7863

stop-download

@alexwykoff alexwykoff changed the title there is no obvious way to stop a torrent download once it has started Added stop button for torrent downloads Apr 25, 2017
@luixxiul luixxiul changed the title Added stop button for torrent downloads Added stop button for torrent downloads - there is no obvious way to stop a torrent download once it has started Apr 26, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.