Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

HTTP auth dialog has no cancel button #6855

Closed
echosa opened this issue Jan 25, 2017 · 3 comments
Closed

HTTP auth dialog has no cancel button #6855

echosa opened this issue Jan 25, 2017 · 3 comments
Labels
QA/checked-Linux QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.13.2

Comments

@echosa
Copy link
Contributor

echosa commented Jan 25, 2017

  • Did you search for similar issues before submitting this one?

Yes.

  • Describe the issue you encountered:

When I'm prompted for HTTP auth, there's no cancel button. You have to press Escape to cancel.

  • Platform (Win7, 8, 10? macOS? Linux distro?):

OS X 10.11.6

  • Brave Version (revision SHA):

0.12.15

  • Steps to reproduce:

    1. Visit a page that asks for HTTP auth.

  • Actual result:

No cancel button exists.

  • Expected result:

A cancel button should exist.

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?

Yes.

  • Is this an issue in the currently released version?

No.

  • Can this issue be consistently reproduced?

Yes.

  • Screenshot if needed:

screen shot 2017-01-25 at 10 22 54 am
@luixxiul
Copy link
Contributor

Wow that's should be fixed soon

@cezaraugusto cezaraugusto mentioned this issue Jan 25, 2017
Merged
4 tasks
@bsclifton bsclifton added this to the 0.13.1 milestone Jan 25, 2017
@bsclifton
Copy link
Member

bsclifton commented Jan 25, 2017 •
edited by luixxiul
Loading

Closed with #6857

Test plan

  • Go to a website that requires basic auth login. i.e. ftp://ftp.unde.co
  • With dialog login open, click "cancel"
  • The Dialog should be closed (same with ESC key)

bsclifton pushed a commit that referenced this issue Jan 26, 2017
@cezaraugusto @bsclifton
Add cancel option for Basic Auth Login
70d69fd 
Auditors: @luixxiul

Fix #6855

Test Plan:
* Go to a website that requires login. i.e. ftp://ftp.unde.co
* With login dialog open, click "cancel"
* Dialog should be closed
This was referenced Feb 3, 2017
Closed
Closed
Closed
Closed
@bbondy bbondy mentioned this issue Feb 3, 2017
Closed
@bbondy
Copy link
Member

bbondy commented Feb 3, 2017

Works on macOS but I posted a followup here for the wrong styles being used on hover:
#7041

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
QA/checked-Linux QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.13.2
Development

No branches or pull requests
6 participants
@echosa @aekeus @bbondy @luixxiul @bsclifton @srirambv