Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Faceblock: FB targeted tracking event assessment & protection #7000

Closed
lukemulks opened this issue Feb 2, 2017 · 5 comments
Closed

Faceblock: FB targeted tracking event assessment & protection #7000

lukemulks opened this issue Feb 2, 2017 · 5 comments
Assignees
Labels
feature/adblock needs-info Another team member needs information from the PR/issue opener. privacy QA/test-plan-required release-notes/include

Comments

@lukemulks
Copy link
Collaborator

  • Did you search for similar issues before submitting this one?
    Y

  • Describe the issue you encountered:
    Within FB and outside of FB, minimal shields are currently applied. We need to update to apply targeted blocking of privacy threats, as FB has folded Atlas agency-level ad tracking into social widgets, etc. in the wild.

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    desktop - all, mobile

  • Brave Version (revision SHA):
    v0.13.1

Need to capture session outside of FB and list events.
Need to capture session w/in FB and list events.
Need to ensure webcompat is considered.
Need to form and submit rules to appropriate shields.

@lukemulks lukemulks added this to the 1.0.0 milestone Feb 2, 2017
@lukemulks lukemulks self-assigned this Feb 2, 2017
@lukemulks lukemulks changed the title Facebook - targeted tracking event assessment & protection Faceblock: FB targeted tracking event assessment & protection Feb 2, 2017
@lukemulks lukemulks added the needs-investigation A bug not 100% confirmed/fixed that needs QA to better audit. label Mar 13, 2017
@lukemulks
Copy link
Collaborator Author

FYI - I'm rolling this issue into a parent initiative that I'm working on for social media network ads (w/in networks, and in embedded widgets and SDKs in the larger Web) - Tracking that initiative here for reference: #7678

@lukemulks
Copy link
Collaborator Author

lukemulks commented Mar 31, 2017

Run checks in FB today, and out of the 3 major blockers (AdBlock Plus, AdBlock, uBlock Origin), uBO is the only one of the three that is effectively blocking within FB.

I focused on uBO, and these are the filters they have in place to block FB ads:

REQUEST filter rules | (I'm going to add these to brave/adblock-lists as custom filters)

||facebook.com/ajax/*logging

  • found in: EasyPrivacy

||facebook.com/xti.php?

  • found in: EasyPrivacy

||facebook.com^*/impression_logging/

  • found in: EasyPrivacy

CSS/DOM ELEMENT hiding filters

facebook.com##:xpath(//div[@id="stream_pagelet"]//div[starts-with(@id,"hyperfeed_story_id_")][.//h6//span/text()="People You May Know"])

  • found in: uBlock filters

facebook.com##.ego_section:has(a.adsCategoryTitleLink)

  • found in: uBlock filters

##.adsCategoryTitleLink

  • found in: EasyList

facebook.com###stream_pagelet div[id^="hyperfeed_story_id_"]:has(a[data-hovercard][href*="hc_ref=ADS"])

  • found in: uBlock filters

facebook.com###pagelet_ego_pane a[ajaxify*="&eid="]

  • found in: EasyList

cc: @bbondy

@lukemulks
Copy link
Collaborator Author

Update: I've done some checking into FB ad and tracking APIs, and have a shortlist for what we can block for tracking outside of FB (as 3rd party tracking)

Need to run a quick test on these, but these are probable:

||connect.facebook.net/*/fbevents.js$third-party
||facebook.com/tr^$image,third-party
||graph.facebook.com^$third-party

Holding off on 1p FB filters, confirming that google and other 3p ads are blocked in FB.

Once tests complete, will update adblock-lists with the filters above.

@lukemulks
Copy link
Collaborator Author

Migrating issue to: brave/adblock-lists#21 for resolution.
Closing issue here given the notes above.

@cndouglas cndouglas removed the needs-investigation A bug not 100% confirmed/fixed that needs QA to better audit. label Apr 11, 2017
@bbondy bbondy modified the milestones: 0.14.2, 1.0.0, 0.15.1 Apr 17, 2017
@luixxiul
Copy link
Contributor

luixxiul commented May 3, 2017

Is there any PoC site?

@luixxiul luixxiul added needs-info Another team member needs information from the PR/issue opener. QA/test-plan-required labels May 3, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature/adblock needs-info Another team member needs information from the PR/issue opener. privacy QA/test-plan-required release-notes/include
Projects
None yet
Development

No branches or pull requests

4 participants