Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Adding, removing, then re-adding a bookmark errors #7016

Closed
bbondy opened this issue Feb 3, 2017 · 0 comments · Fixed by #7024
Closed

Adding, removing, then re-adding a bookmark errors #7016

bbondy opened this issue Feb 3, 2017 · 0 comments · Fixed by #7024
Assignees
@darkdh
Labels
feature/bookmarks QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Milestone
0.13.2

Comments

@bbondy
Copy link
Member

bbondy commented Feb 3, 2017

  • Did you search for similar issues before submitting this one?
    Yes

  • Describe the issue you encountered:
    See title

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    All

  • Brave Version (revision SHA):
    0.13.2-rc1

  • Steps to reproduce:

    1. Visit brave.com
    2. Click the star button to add the bookmark
    3. Click the star button again and click on remove
    4. Click the star button again

  • Actual result:
    The bookmark is not re-added and Shift+f8 console has an error

  • Expected result:
    No error and it re-adds the bookmark

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?
    Yes

  • Is this an issue in the currently released version?
    No

  • Can this issue be consistently reproduced?
    Yes

  • Screenshot if needed:

screenshot 2017-02-02 22 43 39

  • Any related issues:
@bbondy bbondy added this to the 0.13.2 milestone Feb 3, 2017
@bbondy bbondy assigned bbondy and darkdh and unassigned bbondy Feb 3, 2017
darkdh added a commit that referenced this issue Feb 3, 2017
@darkdh
Harden addSite and moveSite
fc20174 
fix #7014
fix #7016

Auditors: @bbondy, @ayumi

Test Plan: covered by automatic test
@darkdh darkdh mentioned this issue Feb 3, 2017
Merged
4 tasks
This was referenced Feb 3, 2017
Closed
Closed
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@darkdh darkdh

Labels
feature/bookmarks QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Projects
None yet
Milestone
0.13.2
Development

Successfully merging a pull request may close this issue.

Harden addSite and moveSite brave/browser-laptop
5 participants
@aekeus @bbondy @luixxiul @darkdh @srirambv