Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Empty bookmark folder should be exported and imported #7193

Closed
luixxiul opened this issue Feb 11, 2017 · 0 comments · Fixed by #7208
Closed

Empty bookmark folder should be exported and imported #7193

luixxiul opened this issue Feb 11, 2017 · 0 comments · Fixed by #7208
Assignees
@darkdh
Labels
feature/bookmarks feature/exporter feature/importer QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.13.5

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Feb 11, 2017 •
edited by bsclifton
Loading

Test Plan

Covered by automatic test
npm run unittest -- --grep="Bookmarks export"

Original issue description

Describe the issue you encountered: Empty bookmark folder should be exported and imported.

  • Platform (Win7, 8, 10? macOS? Linux distro?): Windows 10 32 bit

  • Brave Version (revision SHA): 0.13.3 RC1

  • Steps to reproduce:

    1. Create an empty bookmark folder on the bookmark toolbar
    2. Export the bookmark file
    3. Clear your brave folder
    4. Open the browser
    5. Import the bookmark file

  • Actual result: the empty bookmark folder is gone

  • Expected result: it also should be exported and imported

  • Any related issues:
darkdh added a commit to darkdh/browser-laptop that referenced this issue Feb 12, 2017
@darkdh
Allow empty folder when exporting bookmarks
0cbd918 
fix brave#7193

Auditors: @bsclifton, @NejcZdovc

Test Plan:
Covered by automatic test
@darkdh darkdh mentioned this issue Feb 12, 2017
Merged
4 tasks
@darkdh darkdh self-assigned this Feb 12, 2017
@bsclifton bsclifton modified the milestones: 0.13.3, 0.13.4 Feb 12, 2017
@alexwykoff alexwykoff mentioned this issue Feb 26, 2017
Closed
This was referenced Mar 1, 2017
Closed
Closed
Closed
Closed
This was referenced Mar 3, 2017
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@darkdh darkdh

Labels
feature/bookmarks feature/exporter feature/importer QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.13.5
Development

Successfully merging a pull request may close this issue.

Allow empty folder when exporting bookmarks darkdh/browser-laptop
5 participants
@alexwykoff @luixxiul @bsclifton @darkdh @srirambv